Review main Merged

89591[BUGFIX] Add missing slash in example code

Albrecht Köhnlein CR +2 V +2 Easy +1 −1 updated 05/30/25, 08:05

Commit message

A usage of `<core:icon>` in an example was missing a closing slash. This
caused a Fluid parser exception, if anybody copied the example to his
extension.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Albrecht Köhnlein uploaded patch set 1 05/29/25, 19:52

  2. core-ci voted on patch set 1 V +1 05/29/25, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79671

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 05/29/25, 20:02

  4. Garvin Hicking commented on patch set 1 05/29/25, 20:02

    (debatable if Task or Bugfix, but I can follow classifying it as a bug)
  5. Benni Mack voted on patch set 1 CR +1 V +1 05/30/25, 07:34

  6. Garvin Hicking voted on patch set 1 CR +2 V +2 05/30/25, 07:49

  7. Garvin Hicking merged patch set 2 05/30/25, 08:05