Review main Merged

8967[BUGFIX] Add the title and increase width of the multiple select boxes

Thomas Layh CR +2 V +2 Easy +25 −11 updated 06/03/13, 20:49

Commit message

The db, file and select boxes are too narrow. This makes it hard to
to impossible to read long entries.
Increase the width of those fields and add a title to each entry in
order to allow the user to see the full entry on hover.

Also add a parameter to the javascript function that takes care of the
selection of entries to support the new title attribute.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Philipp Gampe +1

Files 1

Review log 11

  1. Philipp Gampe commented on patch set 1 02/11/12, 08:06

    (4 inline comments) See comments. Also commas need spaces after them. I will upload a new fixed version as soon as I tested it.
    Present tense here.
    a matter of taste, but I prefer "it is" instead of "it's"
    strike "to me"
    added-->adds
  2. Philipp Gampe uploaded patch set 2 02/11/12, 08:06

  3. Philipp Gampe commented on patch set 2 02/11/12, 08:06

    Arg a typo, will work on the commit message again. I just cleaned up the code by introducing a local variable for the title so computations do not need to be done twice. Also wrapped touched lines.
  4. Tolleiv Nietsch commented on patch set 3 V 0 02/11/12, 08:06

    by team member; Looks good to me, approved
  5. Philipp Gampe commented on patch set 3 02/11/12, 08:06

    Verified; Looks good to me, but someone else must approve Any specific reason to choose 310px? I only tested with chrome, but the title tag should work fine for all browsers.
  6. Philipp Gampe uploaded patch set 3 02/11/12, 08:06

  7. Thomas Layh commented on patch set 3 02/11/12, 08:06

    I used 310px because it matches the boxes below.
  8. Mr. Jenkins commented on patch set 1 02/11/12, 08:06

  9. Mr. Jenkins commented on patch set 2 02/11/12, 08:06

  10. Mr. Jenkins commented on patch set 3 02/11/12, 08:06

  11. Tolleiv Nietsch merged patch set 3 02/11/12, 08:06