8967[BUGFIX] Add the title and increase width of the multiple select boxes
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
- Philipp Gampe +1
-
Verified V +2
- Tolleiv Nietsch +2
- Philipp Gampe +1
Files 1
Review log 11
-
Philipp Gampe commented on patch set 1 02/11/12, 08:06
(4 inline comments) See comments. Also commas need spaces after them. I will upload a new fixed version as soon as I tested it.Present tense here.a matter of taste, but I prefer "it is" instead of "it's"strike "to me"added-->adds -
Philipp Gampe uploaded patch set 2 02/11/12, 08:06
-
Philipp Gampe commented on patch set 2 02/11/12, 08:06
Arg a typo, will work on the commit message again. I just cleaned up the code by introducing a local variable for the title so computations do not need to be done twice. Also wrapped touched lines. -
Tolleiv Nietsch commented on patch set 3 V 0 02/11/12, 08:06
by team member; Looks good to me, approved -
Philipp Gampe commented on patch set 3 02/11/12, 08:06
Verified; Looks good to me, but someone else must approve Any specific reason to choose 310px? I only tested with chrome, but the title tag should work fine for all browsers. -
Philipp Gampe uploaded patch set 3 02/11/12, 08:06
-
Thomas Layh commented on patch set 3 02/11/12, 08:06
I used 310px because it matches the boxes below. -
Mr. Jenkins commented on patch set 1 02/11/12, 08:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3203/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/11/12, 08:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3205/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/11/12, 08:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3206/ : SUCCESS -
Tolleiv Nietsch merged patch set 3 02/11/12, 08:06