Review main Abandoned

89670[BUGFIX] Trigger live search after changing options

Georg Ringer CR -1 V -1 Easy +2 −1 updated 06/24/25, 06:44

Commit message

If the user changes the options about the location, the search must
be submitted. As there is no dedicated submit button this is the only
way to update the search.

Review

  • Code review CR -1
    • Andreas Kienast -1
    • Simon Schaufelberger +1
  • Verified V -1
    • Andreas Kienast -1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1415

  1. Georg Ringer uploaded patch set 1 06/08/25, 07:30

  2. Georg Ringer commented on patch set 1 06/08/25, 07:30

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 06/08/25, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80062

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 06/16/25, 08:14

  5. Andreas Kienast commented on patch set 1 V -1 06/17/25, 10:43

    Unresolved

    This will now trigger the search twice: 1. after (de)activating a checkbox 2. after closing the dropdown
  6. Georg Ringer commented on patch set 1 06/17/25, 12:58

    please help me out with an improved patch @akienast@scripting-base.de ^^
  7. Andreas Kienast commented on patch set 1 06/17/25, 14:05

    Reply

    I'm not sure what to improve here. It works exactly as intended to start the filtering once the dropdown is hidden again as a user may select multiple options.
  8. Andreas Kienast commented on patch set 1 06/17/25, 14:39

    Unresolved

    I will work on some general search stuff tomorrow…
  9. Oli Bartsch commented on patch set 1 06/17/25, 15:51

    Reply Unresolved

    I also think that the current mode is the way to go. I personally don't like to have the list filtered whenever I check a option but when I "submit" my selection by closing the filter dropdown.
  10. Georg Ringer commented on patch set 1 06/18/25, 07:08

    but this is not something a user gets anywhere else? the dropdown icons should just toggle the dropdown visibility and has nothing to do with the search functionality. if the double event is bad, remove the one of the toggle!
  11. Andreas Kienast commented on patch set 1 06/18/25, 07:15

    Reply

    Georg. Do you really think it's better to trigger a search everytime the user toggles a checkbox, even if the intent of setting filters is not finished? This WILL lead to unnecessary, potentially heavy requests to the server.
  12. Andreas Kienast commented on patch set 1 CR -1 06/18/25, 07:25

    Unresolved

    Will rework the whole patch to properly use already dispatched events and request tracing.
  13. Georg Ringer commented on patch set 1 06/18/25, 08:31

    Reply Unresolved

    yes!
  14. Andreas Kienast commented on patch set 1 06/18/25, 09:56

    I've pushed an alternative approach: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89754
  15. Georg Ringer abandoned the change 06/24/25, 06:44