Review main Merged Breaking

89709[!!!][TASK] Remove static function parameter in AuthenticationService

Torben Hansen CR +2 V +2 Normal +60 −27 updated 06/12/25, 16:12

Commit message

The parameter `$passwordTransmissionStrategy` for the
function `processLoginData` has a static value, which
results back from the time, where ext:rsaauth has been
removed from the core. Since the parameter has a static
value, it has no value and should be removed.

This patch removes the parameter for the affected
function. Additionally, a meaningful description
as well as strict return types have been added for
the function.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 56

  1. Torben Hansen uploaded patch set 1 06/11/25, 16:44

  2. core-ci voted on patch set 1 V +1 06/11/25, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80214

  3. Georg Ringer voted on patch set 1 CR +1 V +1 06/11/25, 19:15

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 06/12/25, 13:30

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 06/12/25, 16:12

  6. Christian Kuhn merged patch set 2 06/12/25, 16:12