8974[BUGFIX] Unit tests for filebackend fail
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 1
Review log 16
-
Tolleiv Nietsch commented on patch set 1 08/10/12, 08:16
Sorry not able to reproduce. And actually shouldn't the Unittest catch the exception somehow? -
Oliver Klee commented on patch set 1 08/10/12, 08:16
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 1 08/10/12, 08:16
I would prefer that you didn't submit this I remember that I had this problem as well once. I think it was because of a too old phpunit extension. @phillip: Please check out the latest phpunit from TER, or try trunk version of the project on forge. For now I'm -1 to the patch in the file backend itself. -
Philipp Gampe commented on patch set 1 08/10/12, 08:16
I know that this seems to be my specific setup, but exceptions for stream resources are also done in other parts of the caching framework. We could catch the exception in phpunit, but I am not sure whether it will then always want to have it. -
Philipp Gampe commented on patch set 1 08/10/12, 08:16
push -
Philipp Gampe commented on patch set 1 08/10/12, 08:16
Hi Christian, I am on trunk with phpunit from forge. The problem does still exits. -
Christian Kuhn commented on patch set 2 08/10/12, 08:16
I would prefer that you didn't submit this Sry Phillipp, I'm still -1 for this patch. If the tests fail it is imho no solution to change the according code in a way to just suppress the call. Could you please again elaborate your setup and check that the latest phpunit extension is in use? For me, the ter version works fine. Maybe you are using the pear phpunit package or something like that? -
Philipp Gampe commented on patch set 2 08/10/12, 08:16
I just rebased the change. This one is still valid and is the only way to get (almost) green test. -
Philipp Gampe commented on patch set 2 08/10/12, 08:16
I use phpunit r61685 from SVN. I will put more details in the ticket. -
Philipp Gampe uploaded patch set 2 08/10/12, 08:16
-
Philipp Gampe uploaded patch set 3 08/10/12, 08:16
-
Philipp Gampe commented on patch set 3 08/10/12, 08:16
rebased to current master With this patch I get 2 failures currenly, without this patch I get 50 failures, thus 48 more; all related this is problem. I use the master of phpunit. -
Mr. Jenkins commented on patch set 1 08/10/12, 08:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3210/ : SUCCESS -
Mr. Jenkins commented on patch set 2 08/10/12, 08:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4108/ : SUCCESS -
Mr. Jenkins commented on patch set 3 08/10/12, 08:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5186/ : SUCCESS -
Philipp Gampe commented on patch set 3 08/10/12, 08:16
Abandoned I finally found a working workaround: You have to install the rpm packages php-posix (was installed) and php-process (war not installed). Then the tests will be green. http://wiki.typo3.org/Unit_Testing_TYPO3