Review main Merged

8977[FEATURE] Add a "virtual root" to pagetree (for mountpoints)

Stefan Neufeind CR +2 V +2 Normal +52 −1 updated 06/03/13, 20:49

Commit message

If there is no "root" of pages (page 0) shown, add a
"virtual root" that functions as a root for all mountpoints
below it.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Tolleiv Nietsch +1
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Ritter +2
    • Tolleiv Nietsch +1
    • Philipp Gampe +1

Issues 1

Files 3

Review log 19

  1. Tolleiv Nietsch commented on patch set 1 V 0 02/26/12, 19:54

    by team member I bet editors will be very confused by the term "Mountpoints" - technically I like the solution but UX wise I find it complicated
  2. Tolleiv Nietsch commented on patch set 1 02/26/12, 19:54

    Steffen?
  3. Stefan Neufeind commented on patch set 1 02/26/12, 19:54

    @Tolleiv: I agree. My thoughts also included showing the sitename as for the normal root - but that might confuse people as well. Maybe we also need a different icon or so. But that's "cosmetics" :-) If in general the idea is not completely wrong, maybe somebody could contact someone from the usability-team for the details.
  4. Stefan Neufeind commented on patch set 1 02/26/12, 19:54

    I personally think the tree is great since that's what we use in other pages as well. It is a "pagetree". And you can have multiple mountpoints but no "root" above it yet. So what's "above all mountpoints"? Some "root" ... so actually one lever higher in the tree. What else would you add instead? Some entry on the same hierarchy as all the mountpoints saying "I am all the mountpoints" (but not having it a hierarchy-level above)? I don't think so ... Well, do as you please.
  5. Stefan Neufeind commented on patch set 1 02/26/12, 19:54

    Please also read on forge *why* this feature was proposed. The idea is to "reuse" a functionality (tree) we already have in place - just not in the form of a clickable root (hierarchy above all mountpoints). It's not a "cosmetic" change but planned to allow for new functionality across all visible mountpoints in various plugins (like for example the workspaces).
  6. Tolleiv Nietsch commented on patch set 2 02/26/12, 19:54

    Verified; Looks good to me, but someone else must approve Well works for me ... would still be good to get UX input here ....
  7. Stefan Neufeind commented on patch set 2 02/26/12, 19:54

    Checked the logic again. As I understand the virtual root should behave as the normal root (and show "TYPO3" or the sitename if set). We that part of functionality is now reused. getNodes() is called to fetch subpages. In case we create a virtual node we don't return the regular subpages of page 0 there (which would be wrong) but instead the mountpoints. This way pagetree is also free to fetch "all subpages of page 0" if at some point it feels like it (will behave as expected then). In case a temporary mountpoint is used the virtual root is not to be shown.
  8. Stefan Neufeind uploaded patch set 2 02/26/12, 19:54

  9. Stefan Neufeind commented on patch set 2 02/26/12, 19:54

    Since the other items use "pages" and "pages_root" should we maybe call the new root "pages_virtualroot" to have "pages" in the name again?
  10. Stefan Neufeind commented on patch set 2 02/26/12, 19:54

    Regarding UX I briefly chattet with Jens Hoffmann yesterday who didn't seem to have been aware of the recent changes here in gerrit. So I commented it on forge again. Jens suggested to look into this during T3BOARD. It would be great if somebody who is there could please connect the UX-side and the technical side of this review to maybe get it going shortly :-)
  11. Steffen Gebert commented on patch set 1 02/26/12, 19:54

    I would prefer that you didn't submit this Hi, I don't really like it.. are you sure that everybody thinks in trees, like we do? While I would be fine with adding a common ancestor to all mount points, I think it's not good enough, yet, especially as you shift the whole tree to the right and thus create a lot of unused white-space. I move the issue to the UX team.
  12. Steffen Gebert commented on patch set 1 02/26/12, 19:54

    * As stated by Jens the term "Mountpoint" already means something else * Compared to an admin's tree, where the root has a real connection (dotted line) to its children, which are listed directly below. The current implementation in Patch Set 1 a) lacks the dotted line and b) shifts the children one level to the right.
  13. Steffen Ritter commented on patch set 2 V 0 02/26/12, 19:54

    by team member; Looks good to me, approved I was asked from Jens Hoffmann to vote for him +1 in terms of usability. Therefore approved
  14. Steffen Ritter commented on patch set 2 02/26/12, 19:54

    Looks good to me, but someone else must approve
  15. Philipp Gampe commented on patch set 1 02/26/12, 19:54

    Verified; Looks good to me, but someone else must approve Nice one.
  16. Philipp Gampe commented on patch set 2 02/26/12, 19:54

    Verified; Looks good to me, but someone else must approve
  17. Mr. Jenkins commented on patch set 1 02/26/12, 19:54

  18. Mr. Jenkins commented on patch set 2 02/26/12, 19:54

  19. Steffen Ritter merged patch set 2 02/26/12, 19:54