Review TYPO3_4-5 Merged

8979[BUGFIX] Add the title and increase width of the multiple select boxes

Tolleiv Nietsch CR +2 V +2 Easy +25 −11 updated 06/03/13, 20:49

Commit message

The db, file and select boxes are too narrow. This makes it hard
to to impossible to read long entries.
Increase the width of those fields and add a title to each entry
in order to allow the user to see the full entry on hover.
Also add a parameter to the javascript function that takes care of the
selection of entries to support the new title attribute.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Thomas Layh +1
    • Wouter Wolters +1
    • Philipp Gampe +1
  • Verified V +2
    • Georg Ringer +2
    • Thomas Layh +1
    • Wouter Wolters +1
    • Philipp Gampe +1

Files 1

Review log 16

  1. Tolleiv Nietsch uploaded patch set 2 03/06/12, 06:15

  2. Philipp Gampe commented on patch set 2 03/06/12, 06:15

    Looks good to me, but someone else must approve
  3. Philipp Gampe uploaded patch set 3 03/06/12, 06:15

  4. Philipp Gampe commented on patch set 3 03/06/12, 06:15

    Verified; Looks good to me, but someone else must approve Rebased.
  5. Philipp Gampe uploaded patch set 4 03/06/12, 06:15

  6. Philipp Gampe commented on patch set 4 03/06/12, 06:15

    Verified; Looks good to me, but someone else must approve Sorry, rebased to wrong branch :]
  7. Philipp Gampe commented on patch set 4 03/06/12, 06:15

    I would prefer that you didn't submit this And I f*** up the commit message once more :/
  8. Philipp Gampe uploaded patch set 5 03/06/12, 06:15

  9. Philipp Gampe commented on patch set 5 03/06/12, 06:15

    Verified; Looks good to me, but someone else must approve
  10. Philipp Gampe commented on patch set 6 03/06/12, 06:15

    Verified; Looks good to me, but someone else must approve wow.... what a mess, now everything should be back to normal ... author is now set correctly again. I must apologize, I messed with the commit message quite a lot :(
  11. Philipp Gampe uploaded patch set 6 03/06/12, 06:15

  12. Thomas Layh commented on patch set 2 03/06/12, 06:15

    Verified; Looks good to me, but someone else must approve
  13. Thomas Layh commented on patch set 6 03/06/12, 06:15

    Verified; Looks good to me, but someone else must approve
  14. Wouter Wolters commented on patch set 6 03/06/12, 06:15

    Verified; Looks good to me, but someone else must approve
  15. Georg Ringer commented on patch set 6 V 0 03/06/12, 06:15

    by team member; Looks good to me, approved
  16. Georg Ringer merged patch set 6 03/06/12, 06:15