Review main Merged

8987[FEATURE] Toolbar Separator

Felix Kopp CR +2 V +2 Normal +39 −52 updated 06/03/13, 20:49

Commit message

Adds separator style to toolbar items. Also the positioning of fly-out menus is
reworked and does not rely on JavaScript anymore.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Tolleiv Nietsch +1
  • Verified V +2
    • Steffen Ritter +2
    • Tolleiv Nietsch +1

Files 7

Review log 6

  1. Tolleiv Nietsch merged patch set 1 02/16/12, 22:43

  2. Tolleiv Nietsch commented on patch set 1 02/16/12, 22:43

    Verified; Looks good to me, but someone else must approve Works in FF, Chrome and Safari.
  3. Steffen Ritter commented on patch set 1 V 0 02/16/12, 22:43

    by team member; Looks good to me, approved
  4. Felix Kopp commented on patch set 1 02/16/12, 22:43

    Thanks for the super-fast reviews!
  5. Mr. Jenkins commented on patch set 1 02/16/12, 22:43

  6. Steffen Gebert commented on patch set 1 02/16/12, 22:43

    What about testing UI changes in our beloved Internet Explorer??