89872[BUGFIX] Search also additional file metadata fields
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1215
-
Uwe Wiebach uploaded patch set 1 06/25/25, 11:07
-
core-ci voted on patch set 1 V +1 06/25/25, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80848
-
Mathias Brodala commented on patch set 1 06/25/25, 11:32
-
Uwe Wiebach commented on patch set 1 06/25/25, 11:42
sys_file_metadata.php:8ReplyBut the field 'description' was not even added here - it's already in the TCA definition in EXT:core... Which fields do you think should not be searchable? -
Oli Bartsch commented on patch set 1 V -1 06/25/25, 11:46
Hi Uwe, thanks for your patch. While it totally makes sense to have more metadata fields searchable, I wonder if we still need this, based on the introduction of the SearchableSchemaFieldsCollector, see https://review.typo3.org/c/Packages/TYPO3.CMS/+/88013. -
Uwe Wiebach commented on patch set 1 06/25/25, 12:02
Reply
As far as I see you still need to define the searchFields or have none set at all. Is that correct? If so, I should have changed the TCA definition of sys_file_metadata in EXT:core as there the fields 'title', 'description' and 'alternative' are set as searchFields. -
Oli Bartsch commented on patch set 1 06/25/25, 12:13
Reply
Yes, you're right, we would need to remove the "searchFields" in the core class. Would you like to update the patch accordingly? Also please convert this into a bugfix. I would not consider this a FEATURE. Additionally, features are not "allowed" to be backported. -
Uwe Wiebach uploaded patch set 2
V +106/25/25, 12:54 -
core-ci voted on patch set 2 V +1 06/25/25, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80857
-
Uwe Wiebach updated the commit message in patch set 3
V +106/25/25, 13:10 -
core-ci voted on patch set 3 V +1 06/25/25, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80862
-
Oli Bartsch commented on patch set 3 CR +1 V +1 06/25/25, 14:36
Reply
DoneThanks!sys_file_metadata.php:8ReplyDone -
Benni Mack voted on patch set 3 CR +1 V +1 06/25/25, 19:44
-
Oli Bartsch voted on patch set 3 CR +2 V +2 06/25/25, 20:45
-
Oli Bartsch merged patch set 4 06/25/25, 20:45
sys_file_metadata.php:8