Review main Merged

89886[BUGFIX] Use table alias in WorkspaceRestriction

Christian Kuhn CR +2 V +2 Normal +140 −90 updated 06/25/25, 21:52

Commit message

The WorkspaceRestriction misses a table alias in one
place which leads to "ambiguous" und thus failing
SQL when a table is joined that has column
"t3ver_state" as well.

The patch turns the existing unit tests into functional
tests and adds a case to verify the fix.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 812

  1. Christian Kuhn uploaded patch set 1 06/25/25, 15:49

  2. core-ci voted on patch set 1 V +1 06/25/25, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80878

  3. Christian Kuhn uploaded patch set 2 V +1 06/25/25, 17:31

  4. Christian Kuhn uploaded patch set 3 06/25/25, 17:40

  5. core-ci voted on patch set 2 V -1 06/25/25, 17:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80887

  6. core-ci voted on patch set 3 V -1 06/25/25, 17:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80888

  7. Christian Kuhn uploaded patch set 4 V -1 06/25/25, 17:53

  8. core-ci voted on patch set 4 V +1 06/25/25, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80890

  9. Stefan Bürk voted on patch set 4 CR +1 V +1 06/25/25, 18:03

  10. Benni Mack commented on patch set 4 CR +1 V +1 06/25/25, 19:18

    FYI @bo@cedev.de
  11. Christian Kuhn voted on patch set 4 CR +2 V +2 06/25/25, 21:52

  12. Christian Kuhn merged patch set 5 06/25/25, 21:52