8989[TASK] EM: Move Upload button to top button menu
Commit message
Review
-
Code review CR +2
- Steffen Gebert +2
- Markus Klein +1
- Stefan Galinski +1
- Philipp Gampe +1
-
Verified V +2
- Steffen Gebert +2
- Markus Klein +1
- Stefan Galinski +1
- Philipp Gampe +1
Files 3
Review log 27
Show 2 earlier messages
-
Tolleiv Nietsch commented on patch set 2 02/13/12, 22:33
Looks good to me, approved Well it works but the issue number can't be correct, #32753 is related to the scheduler. -
Tolleiv Nietsch commented on patch set 2 V 0 02/13/12, 22:33
by team member; No score -
Markus Klein commented on patch set 2 02/13/12, 22:33
Maybe it's best to create one. We never had a commit without Resolves/Fixes before. -
Markus Klein uploaded patch set 2 02/13/12, 22:33
-
Markus Klein commented on patch set 2 02/13/12, 22:33
Verified; Looks good to me, but someone else must approve Changed to TASK as all patches from #32753. -
Markus Klein commented on patch set 2 02/13/12, 22:33
That's why it's Related not Resolves. ;-) -
Felix Kopp commented on patch set 2 02/13/12, 22:33
Shall a new issues be created: Could also just connect the issues on forge and not here in the commit? -
Markus Klein commented on patch set 3 02/13/12, 22:33
Verified; Looks good to me, but someone else must approve IMO this is not a UI change. It's just implementing what has been there everywhere else. -
Stefan Galinski commented on patch set 3 02/13/12, 22:33
Verified; Looks good to me, but someone else must approve No problem, but it's still inside the UX/UI project. Is this allowed and doesn't leads to problems afterwards? Will this issue be auto-resolved after merging or does it needs manually work? -
Steffen Gebert commented on patch set 3 02/13/12, 22:33
I would prefer that you didn't submit this Please no UI changes without feedback from the UX/UI team! -
Steffen Gebert commented on patch set 3 02/13/12, 22:33
yes, it would work, but I'll move it back right now -
Steffen Gebert commented on patch set 3 02/13/12, 22:33
BTW: The "top main menu" is called "docheader" -
Steffen Gebert commented on patch set 3 V 0 02/13/12, 22:33
by team member; Looks good to me, approved submitting -
Steffen Gebert commented on patch set 3 02/13/12, 22:33
No score -
Steffen Gebert commented on patch set 3 02/13/12, 22:33
Review from team member missing -
Philipp Gampe commented on patch set 3 02/13/12, 22:33
Verified; Looks good to me, but someone else must approve Works nice. -
Simon Schaufelberger commented on patch set 3 02/13/12, 22:33
can somebody press the commit button here please? -
Simon Schaufelberger commented on patch set 3 02/13/12, 22:33
sorry i mean the submit button ;) -
Felix Kopp commented on patch set 3 02/13/12, 22:33
Hey Steffen, got OK by usability team. Could you please remove your -1 so that this could be included in 4.7? -
Felix Kopp uploaded patch set 3 02/13/12, 22:33
-
Felix Kopp commented on patch set 3 02/13/12, 22:33
Thank you all very much!! -
Mr. Jenkins commented on patch set 1 02/13/12, 22:33
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3219/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/13/12, 22:33
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3220/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/13/12, 22:33
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3221/ : SUCCESS -
Felix Kopp commented on patch set 3 02/13/12, 22:33
Thank you for all the hassles