Review main Merged

8989[TASK] EM: Move Upload button to top button menu

Felix Kopp CR +2 V +2 Easy +8 −15 updated 06/03/13, 20:49

Commit message

Moves the button Upload Extension directly to
the top main button menu.

Review

  • Code review CR +2
    • Steffen Gebert +2
    • Markus Klein +1
    • Stefan Galinski +1
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Gebert +2
    • Markus Klein +1
    • Stefan Galinski +1
    • Philipp Gampe +1

Files 3

Review log 27

Show 2 earlier messages
  1. Steffen Gebert merged patch set 1 02/13/12, 22:33

  2. Markus Klein commented on patch set 1 02/13/12, 22:33

    Verified; Looks good to me, but someone else must approve
    EM: is sufficient
  1. Tolleiv Nietsch commented on patch set 2 02/13/12, 22:33

    Looks good to me, approved Well it works but the issue number can't be correct, #32753 is related to the scheduler.
  2. Tolleiv Nietsch commented on patch set 2 V 0 02/13/12, 22:33

    by team member; No score
  3. Markus Klein commented on patch set 2 02/13/12, 22:33

    Maybe it's best to create one. We never had a commit without Resolves/Fixes before.
  4. Markus Klein uploaded patch set 2 02/13/12, 22:33

  5. Markus Klein commented on patch set 2 02/13/12, 22:33

    Verified; Looks good to me, but someone else must approve Changed to TASK as all patches from #32753.
  6. Markus Klein commented on patch set 2 02/13/12, 22:33

    That's why it's Related not Resolves. ;-)
  7. Felix Kopp commented on patch set 2 02/13/12, 22:33

    Shall a new issues be created: Could also just connect the issues on forge and not here in the commit?
  8. Markus Klein commented on patch set 3 02/13/12, 22:33

    Verified; Looks good to me, but someone else must approve IMO this is not a UI change. It's just implementing what has been there everywhere else.
  9. Stefan Galinski commented on patch set 3 02/13/12, 22:33

    Verified; Looks good to me, but someone else must approve No problem, but it's still inside the UX/UI project. Is this allowed and doesn't leads to problems afterwards? Will this issue be auto-resolved after merging or does it needs manually work?
  10. Steffen Gebert commented on patch set 3 02/13/12, 22:33

    I would prefer that you didn't submit this Please no UI changes without feedback from the UX/UI team!
  11. Steffen Gebert commented on patch set 3 02/13/12, 22:33

    yes, it would work, but I'll move it back right now
  12. Steffen Gebert commented on patch set 3 02/13/12, 22:33

    BTW: The "top main menu" is called "docheader"
  13. Steffen Gebert commented on patch set 3 V 0 02/13/12, 22:33

    by team member; Looks good to me, approved submitting
  14. Steffen Gebert commented on patch set 3 02/13/12, 22:33

    No score
  15. Steffen Gebert commented on patch set 3 02/13/12, 22:33

    Review from team member missing
  16. Philipp Gampe commented on patch set 3 02/13/12, 22:33

    Verified; Looks good to me, but someone else must approve Works nice.
  17. Simon Schaufelberger commented on patch set 3 02/13/12, 22:33

    can somebody press the commit button here please?
  18. Simon Schaufelberger commented on patch set 3 02/13/12, 22:33

    sorry i mean the submit button ;)
  19. Felix Kopp commented on patch set 3 02/13/12, 22:33

    Hey Steffen, got OK by usability team. Could you please remove your -1 so that this could be included in 4.7?
  20. Felix Kopp uploaded patch set 3 02/13/12, 22:33

  21. Felix Kopp commented on patch set 3 02/13/12, 22:33

    Thank you all very much!!
  22. Mr. Jenkins commented on patch set 1 02/13/12, 22:33

  23. Mr. Jenkins commented on patch set 2 02/13/12, 22:33

  24. Mr. Jenkins commented on patch set 3 02/13/12, 22:33

  25. Felix Kopp commented on patch set 3 02/13/12, 22:33

    Thank you for all the hassles