8992[BUGFIX] show uid of reference in show_item.php
Commit message
Review
-
Code review CR +2
- Thorsten Kahler +2
- Philipp Gampe +1
-
Verified V +2
- Thorsten Kahler +2
- Philipp Gampe +1
Files 1
Review log 35
Show 10 earlier messages
-
Thorsten Kahler uploaded patch set 3 02/13/12, 15:08
-
Thorsten Kahler commented on patch set 4 02/13/12, 15:08
(2 inline comments) -
Thorsten Kahler uploaded patch set 4 02/13/12, 15:08
-
Markus Klein commented on patch set 2 02/13/12, 15:08
Looks good to me, but someone else must approve Fixed missing </span> -
Markus Klein uploaded patch set 2 02/13/12, 15:08
-
Johannes Feustel commented on patch set 4 02/13/12, 15:08
(2 inline comments)show_item.php:492Can a new column be introduced in a bugfix release?show_item.php:505htmlspecialchars is already in getRecordTitle(). I think there should be some whitespaces and "page" should be localized.show_item.php:505Replyhtmlspecialchars() is alredy done in getRecordTitlePrep() Edit: just saw that $prep parameter is not set. Probably because it should not crop the page title in the tooltip. I will re-add htmlspecialchars() soon. -
Thorsten Kahler commented on patch set 5 02/13/12, 15:08
(1 inline comment) -
Thorsten Kahler commented on patch set 5 1 comment 02/13/12, 15:08
Verified; I would prefer that you didn't submit this Code works for me but a htmlspecialchars() should be added for security reasosns. -
Markus Klein commented on patch set 5 02/13/12, 15:08
(1 inline comment) -
Thorsten Kahler commented on patch set 6 2 comments 02/13/12, 15:08
I would prefer that you didn't submit this
-
Markus Klein commented on patch set 6 02/13/12, 15:08
Would it be better to use getRecordTitle( , , FALSE, TRUE) This would simply print "No title" without any <em> around. -
Markus Klein uploaded patch set 6 02/13/12, 15:08
-
Markus Klein commented on patch set 6 02/13/12, 15:08
(1 inline comment) -
Thorsten Kahler commented on patch set 7 1 comment 02/13/12, 15:08
Verified; I would prefer that you didn't submit this -
Markus Klein uploaded patch set 7 02/13/12, 15:08
-
Markus Klein commented on patch set 7 02/13/12, 15:08
(1 inline comment) -
Thorsten Kahler commented on patch set 8 V 0 02/13/12, 15:08
by team member; Looks good to me, approved -
Markus Klein uploaded patch set 8 02/13/12, 15:08
-
Johannes Feustel commented on patch set 5 02/13/12, 15:08
(1 inline comment) -
Johannes Feustel uploaded patch set 5 02/13/12, 15:08
-
Johannes Feustel commented on patch set 6 02/13/12, 15:08
Looks good to me, but someone else must approve -
Johannes Feustel commented on patch set 6 02/13/12, 15:08
(1 inline comment) -
Philipp Gampe commented on patch set 6 02/13/12, 15:08
No score One issue ... if the referenced page is the TYPO3 root (pid=0) it says "<em>[No title}</em>" in the popup. Maybe there needs to be some extra logic to handle this case, because this is really ugly.show_item.php:492That looks strange. Maybe use Uid or uid instead? Or make "Unique Id" a label? -
Philipp Gampe voted on patch set 6 V 0 1 comment 02/13/12, 15:08
-
Philipp Gampe commented on patch set 7 02/13/12, 15:08
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 8 02/13/12, 15:08
Verified; Looks good to me, but someone else must approve Sorry, I overlooked that one too. -
Mr. Jenkins commented on patch set 1 02/13/12, 15:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3222/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/13/12, 15:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3223/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/13/12, 15:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3225/ : SUCCESS -
Mr. Jenkins commented on patch set 4 02/13/12, 15:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3226/ : SUCCESS -
Mr. Jenkins commented on patch set 5 02/13/12, 15:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3228/ : SUCCESS -
Mr. Jenkins commented on patch set 6 02/13/12, 15:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3235/ : SUCCESS -
Mr. Jenkins commented on patch set 7 02/13/12, 15:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3236/ : SUCCESS -
Mr. Jenkins commented on patch set 8 02/13/12, 15:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3237/ : SUCCESS -
Thorsten Kahler merged patch set 8 02/13/12, 15:08