Review main Merged

89930[BUGFIX] Ensure further variable fallback checks in EXT:felogin

Garvin Hicking CR +2 V +2 Easy +3 −3 updated 06/27/25, 10:49

Commit message

With #106942 changes were made to prevent PHP type errors / exceptions
in case the EXT:felogin TypoScript was not included.

Two spots were missed, which is addressed by this patch.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Garvin Hicking uploaded patch set 1 06/27/25, 07:28

  2. core-ci voted on patch set 1 V +1 06/27/25, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81058

  3. Torben Hansen voted on patch set 1 CR +1 V +1 06/27/25, 08:17

  4. Oli Bartsch voted on patch set 1 CR +1 V +1 06/27/25, 10:13

  5. Garvin Hicking voted on patch set 1 CR +2 V +2 06/27/25, 10:14

  6. Garvin Hicking merged patch set 2 06/27/25, 10:49