Review main Abandoned

90046[WIP][TASK] Add Claude Code documentation and configuration

Benni Mack CR 0 V 0 Hard +600 −0 updated 08/14/25, 14:16

Commit message

This is a first WIP to add Claude code instructions.

What does it do?

- Add comprehensive CLAUDE.md with development commands overview
- Add settings.local.json to .gitignore for local configs

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Files 4

Review log 810

  1. Benni Mack uploaded patch set 1 07/10/25, 12:20

  2. core-ci voted on patch set 1 V +1 07/10/25, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81559

  3. Benjamin Franzke commented on patch set 1 07/10/25, 13:20

    CLAUDE.md:1 Unresolved

    Hm, everyone using HACKING.md for this kind of information, but this AI needs an own instruction file? :( https://docs.anthropic.com/en/docs/claude-code/github-actions#claude-md-configuration What a redundancy having to document this kind of information for (every?) AI.
  4. Benjamin Franzke commented on patch set 1 07/10/25, 13:24

    CLAUDE.md Unresolved

    This file is meant to be placed in the project root: > Create a CLAUDE.md file in your repository root to define code style guidelines, review criteria, project-specific rules, and preferred patterns. https://docs.anthropic.com/en/docs/claude-code/github-actions#claude-md-configuration How is Claude instructed to read this file instead? Do we need documentation how to make claude find it's documentation? If so: could it also be a generic file (HACKING.md)?
  5. Garvin Hicking commented on patch set 1 07/10/25, 17:12

    CLAUDE.md:45 Unresolved

    To prevent redundancy could we make a runTests.sh command that outputs its help directly into this file? loke runTests -h rebuildClownInstructions? Or maybe even put this into our Coding Guidelines docs, add an "export" to this file? Otherwise I think we should harmonize and "connect" our coding guidelines with this document to prevent discrepancie and out-of-date-ness.
  6. Oli Bartsch uploaded patch set 2 V +1 07/18/25, 09:06

  7. core-ci voted on patch set 2 V +1 07/18/25, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81909

  8. Benjamin Kott commented on patch set 2 07/18/25, 09:21

    CLAUDE.md:17 Unresolved

    this misses information on how to use the correct npm version aka nvm

    CLAUDE.md:158 Unresolved

    this is not correct it needs to follow our php cs-fixer settings

    CLAUDE.md:166 Unresolved

    it should read the eslint config before to make the correct assignments in the first place

    CLAUDE.md:171 Unresolved

    this is invalid we are not using doctrine migrations
  9. Benjamin Kott commented on patch set 2 07/18/25, 09:22

    CLAUDE.md:41 Unresolved

    misses part of edtorconfig and file formatting
  10. Benni Mack abandoned the change 08/14/25, 14:16