Review main Merged

9006[FEATURE] Create interface and enable custom form_postProcessors

Franz Geiger CR +2 V +2 Normal +235 −9 updated 06/03/13, 20:49

Commit message

PostProcessors now need to implement the
tx_form_System_Postprocessor_Interface.
All classes implementing this interface can be loaded as a
postProcessor by passing its class-name by typoscript.

Before loading the class in the namespace 'tx_form_System_Postprocessor_'
tx_form_System_Postprocessor first tries to load the class passed by
typoscript directly.

Review

  • Code review CR +2
    • Susi Moog +2
  • Verified V +2
    • Susi Moog +2

Issues 1

Files 4

Review log 39

Show 14 earlier messages
  1. Stefan Neufeind commented on patch set 1 07/01/12, 12:08

    (3 inline comments) Nice addition. I thought it already supported that :-) Just some minor nitpicks.
    mention adding the interface as well

    Postprocessor.php:70

    the makeInstance() and the call to process() could be done once and not twice in both if-blocks here. So you'd just check if this class here exists or a class with the extended className from above and do the further processing only once. Maybe define $className above to be a temporary $classNameExpanded or so? Then you could set $className = FALSE initially, and set it once a class_exists triggered? And maybe you could check if that class implements the interface we expect (using instanceof).

    Postprocessor.php:85

    maybe drop that newline from the fileend
  2. Mr. Jenkins commented on patch set 1 07/01/12, 12:08

  3. Mr. Jenkins commented on patch set 2 07/01/12, 12:08

  4. Franz Geiger uploaded patch set 2 07/01/12, 12:08

    Postprocessor.php:88

    I don't know why it says there was a newline. There's none in my local file.

    Postprocessor.php:88 Reply

    So, no there is no newline at end of file, as Stefan suggested.

    Wizard.php:253 Reply

    Fair enough. I just thought this is still part of making forms extendable with custom postprocessors. And since it doesn't look as if this patch will be reviewed any time soon, I could also just include the patch for that and get started by discussing where the patch should go. That probably really fits better in a new feature request. I'll write one.
  5. Stefan Neufeind uploaded patch set 4 07/01/12, 12:08

  6. Stefan Neufeind commented on patch set 4 07/01/12, 12:08

    Looks good to me, but someone else must approve removed newline, added release-tag to commit-message If I'm right we'll need to add a bug for pending documentation and add it over there once this here is accepted. Read the source again as well as the proposed documentation. Looks fine to me.
  7. Stefan Neufeind commented on patch set 4 07/01/12, 12:08

    "+1 reading" from Susanne should still be valid as well since I didn't really change much
  8. Susi Moog commented on patch set 3 07/01/12, 12:08

    Looks good to me, but someone else must approve Would you also update the documentation accordingly?
  9. Philipp Gampe commented on patch set 3 07/01/12, 12:08

    @Franz have a look at the unified view It says that there is no newline at eof What really happens is that you either add or remove the newline char ('\n') at the end of the very last line of the file. Both is absolutely fine for PHP and CGL. It is just a matter of taste whether the file should end in the "middle" of the last line or have an ending newline char. Git notices the change in the binary stream, but diff can not display it, thus this warning (which shows as change in Gerrit). A single '\n' is considered to be part of the "?>" by PHP.
  10. Philipp Gampe commented on patch set 3 07/01/12, 12:08

    @Franz You can either update the manual and add it to this patch (but I suggest making a new patch for the manual) or you can create a new issue and just put the new text in that issue. Then link the documentation issue with the patch issue and post the issue number here.
  11. Mr. Jenkins commented on patch set 3 07/01/12, 12:08

  12. Mr. Jenkins commented on patch set 4 07/01/12, 12:08

  13. Franz Geiger commented on patch set 3 07/01/12, 12:08

    Proposed description of postprocessors to be indluded in documentation is attached to http://forge.typo3.org/issues/34021
  14. Franz Geiger commented on patch set 3 07/01/12, 12:08

    @Susanne, certainly. How and where can I update the documentation?
  1. Franz Geiger uploaded patch set 3 07/01/12, 12:08

  2. Franz Geiger commented on patch set 3 07/01/12, 12:08

    (1 inline comment) Sorry for pushing the partial patch 2. Does someone know why diff sees a newline where I can't see one?
  3. Franz Geiger commented on patch set 3 07/01/12, 12:08

    (1 inline comment) @Philipp, thx. No I understand. Since there now is no newline at end of file, everything is as Stafan suggested – I at least hope so.
  4. Franz Geiger commented on patch set 3 07/01/12, 12:08

    Hi everybody! Did I miss to do something to get this patch reviewed? Am I supposed to review it myself to get the reviewing process started? Any help is appreciated, thanks.
  5. Stefan Neufeind commented on patch set 5 07/01/12, 12:08

    (2 inline comments)
  6. Philipp Gampe commented on patch set 5 07/01/12, 12:08

    @Franz, will you provide a new version?
  7. Philipp Gampe commented on patch set 5 07/01/12, 12:08

    Well, there are whitespace issues and the releases line needs to be touched. I can do that of course, but I though you might want to provide an update on your own. Also I wasn't sure whether you are going to extend this patch or not. If nothing technically changed, I can just push a new version. I just do not want to mess all up in case you have a local working copy and then we would need to merge changes or even worse, push competing patch sets :)
  8. Mr. Jenkins commented on patch set 5 07/01/12, 12:08

  9. Franz Geiger commented on patch set 5 07/01/12, 12:08

    (1 inline comment)
  10. Franz Geiger uploaded patch set 5 07/01/12, 12:08

  11. Franz Geiger commented on patch set 5 07/01/12, 12:08

    @Philipp, why should I provide a new patch? Isn't stefan's patch 4 still good? Do you mean I should implement the hook? As stefan suggested, I created a new feature request and attached the patch to that request. What else do you think I should change?
  12. Stefan Neufeind commented on patch set 6 07/01/12, 12:08

    (2 inline comments) just minor things. will post an update
  13. Stefan Neufeind commented on patch set 7 07/01/12, 12:08

    Looks good to me, but someone else must approve took care of previous comments
  14. Stefan Neufeind uploaded patch set 7 07/01/12, 12:08

  15. Susi Moog uploaded patch set 8 07/01/12, 12:08

  16. Susi Moog commented on patch set 8 07/01/12, 12:08

    Verified; Looks good to me, but someone else must approve Looks good, really nice addition. I just added unit tests and moved one line around for (minimal ;)) performance reasons.
  17. Susi Moog uploaded patch set 9 07/01/12, 12:08

  18. Georg Ringer commented on patch set 6 07/01/12, 12:08

    (1 inline comment)
  19. Mr. Jenkins commented on patch set 8 07/01/12, 12:08

  20. Wouter Wolters commented on patch set 8 3 comments 07/01/12, 12:08

    Verified; Looks good to me, but someone else must approve Some small CGL things
  21. Franz Geiger commented on patch set 6 07/01/12, 12:08

    @Philipp: I reverted the changes in Wizard.php. Patch 6 now equals patch 4. The extension of which I talked in the comment in patch 5 was already merged: https://review.typo3.org/9559 I also changed the release number to 4.8.
  22. Franz Geiger uploaded patch set 6 07/01/12, 12:08

  23. Franz Geiger commented on patch set 7 07/01/12, 12:08

    Looks good to me, but someone else must approve @Stefan: Thanks to tidy up my work. I know one should be patient. But will this ever by merged?
  24. Susi Moog commented on patch set 9 V 0 07/01/12, 12:08

    by team member; Looks good to me, approved Last patch set just fixed Wouters CGL issues. Merging now.
  25. Susi Moog merged patch set 9 07/01/12, 12:08