Review main Merged

90082[BUGFIX] Fix blurry WebP and AVIF images

Manfred Egger CR +2 V +2 Easy +2 −0 updated 07/29/25, 06:38

Commit message

Apply sharpening of WebP and AVIF images
in the same way as JPEGs.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Manfred Egger uploaded patch set 1 07/17/25, 05:27

  2. core-ci voted on patch set 1 V +1 07/17/25, 05:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81803

  3. Benni Mack voted on patch set 1 CR +1 V +1 07/21/25, 10:52

  4. Garvin Hicking commented on patch set 1 07/21/25, 14:45

    What about new formats like avif? Or gif and other formats listed in `->imageFileExt`? Could we add this more generically without missing new file formats if they come up like heic and others? I didn't try yet what happens if `-sharpen` is assigned to a target output file like pdf or ai (vectors), maybe they could be silently discarded and then we could add them to every processing, only depending on bool processor_effects?
  5. Manfred Egger commented on patch set 1 07/25/25, 06:24

    Reply

    I made some tests with forcing fileExtension to PNG and PDF. The resulting files look better if the sharpen parameter is added. So maybe this should be in place for all file extensions? Or maybe only for `$webImageExt`/array keys of `$cmds` which would disable it for pdf or ai. I'm not sure, if I am the right for those type of changes to the core. Let me know, if I should adapt the patch or someone else takes over 😉
  6. Christian Kuhn commented on patch set 1 CR +1 07/28/25, 16:05

    Reply

    i'd be fine with doing this change now and have a look at further formats with a separate change?
  7. Garvin Hicking commented on patch set 1 07/28/25, 16:07

    Reply

    maybe add at least avif then already which we support?
  8. Manfred Egger rebased onto patch set 2 CR +1 V +1 07/29/25, 05:33

  9. core-ci voted on patch set 2 V +1 07/29/25, 05:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82461

  10. Benni Mack commented on patch set 3 V +1 07/29/25, 06:09

    Published edit on patch set 2.
  11. Benni Mack commented on patch set 3 CR +1 V +1 07/29/25, 06:10

    Reply

    Done
  12. Garvin Hicking voted on patch set 3 CR +2 V +2 07/29/25, 06:15

  13. core-ci voted on patch set 3 V +1 07/29/25, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82464

  14. Garvin Hicking merged patch set 4 07/29/25, 06:38