Review main Merged

90145[TASK] Allow imports in site set `settings.yaml` files

Elias Häußler CR +2 V +2 Normal +65 −7 updated 07/25/25, 06:50

Commit message

With this patch, YAML imports in site set `settings.yaml` files are now
processed when loading a site set. This applies to `settings.yaml` files
only; `settings.definitions.yaml` files are explicitly not covered by
this change.

By allowing YAML imports in `settings.yaml` files, it is now possible to
maintain a clear structure of possibly complex site set settings,
especially if a lot of subsets are used. This streamlines settings.yaml
to better match existing site-specific settings.yaml features.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 710

  1. Elias Häußler uploaded patch set 1 07/24/25, 14:31

  2. core-ci voted on patch set 1 V -1 07/24/25, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82251

  3. Elias Häußler uploaded patch set 2 V -1 07/24/25, 14:45

  4. core-ci voted on patch set 2 V +1 07/24/25, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82254

  5. Benjamin Franzke uploaded patch set 3 V +1 07/24/25, 14:56

  6. core-ci voted on patch set 3 V +1 07/24/25, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82256

  7. Garvin Hicking commented on patch set 3 V -1 07/24/25, 16:21

    let me check something pls, later this evening
  8. Garvin Hicking commented on patch set 3 CR +1 V +1 07/24/25, 17:51

    Reply

    Done
  9. Benjamin Franzke voted on patch set 3 CR +2 V +2 07/25/25, 06:50

  10. Benjamin Franzke merged patch set 4 07/25/25, 06:50