Review main Merged

90198[TASK] Fix duplicate styleguide ext_conf_template category IDs

Benjamin Franzke CR +2 V +2 Easy +2 −2 updated 08/01/25, 08:57

Commit message

The styleguide extension configuration options `options_2` and `int_3`
where overwritten by invalid category configurations in `options_3`
and `intplus_3`. These are fixed to use a unique category specifier
instead.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Andreas Kienast +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Benjamin Franzke uploaded patch set 1 07/30/25, 08:30

  2. Garvin Hicking voted on patch set 1 CR +1 V +1 07/30/25, 08:35

  3. core-ci voted on patch set 1 V +1 07/30/25, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82549

  4. Simon Schaufelberger commented on patch set 1 CR +1 V +1 07/30/25, 08:52

    I would call it a BUGFIX instead of a TASK but ok...
  5. Oliver Klee voted on patch set 1 CR +1 07/30/25, 09:19

  6. Benjamin Franzke commented on patch set 1 07/30/25, 09:26

    Reply

    Thanks for your feedback. My reasoning is: It's not a BUG in our application that an enduser faces. This aspect of `EXT:styleguide` is targeted for testing variants and therefore does not qualify as a BUGFIX, but as a cleanup.
  7. Simon Schaufelberger commented on patch set 1 07/30/25, 09:39

    Reply

    ok then ready to merge!
  8. Andreas Kienast voted on patch set 1 CR +1 V +1 08/01/25, 08:46

  9. Benjamin Franzke voted on patch set 1 CR +2 V +2 08/01/25, 08:46

  10. Benjamin Franzke merged patch set 2 08/01/25, 08:57