Review main Merged

90202[BUGFIX] Support password managers to autofill new password confirmation

Benjamin Kott CR +2 V +2 Easy +1 −1 updated 08/01/25, 09:53

Commit message

For maximum compatibility with all password managers it is suggested to
add `autocomplete="new-password"` in password changing forms both on the
new password field and on the repeating password field, see:
https://www.youtube.com/watch?v=o2wkYzu5u50&t=2297s

Please be aware that some password managers like 1Password, already
automagically fill the current `autocomplete="off"` password
confirmation field, but the builtin Google Chrome password manager
honors `autocomplete="off"` and does not autofill this field and instead
expects `autocomplete="new-password"` for "suggest password" to autofill
both fields when generating a new random password.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Benjamin Kott uploaded patch set 1 07/30/25, 19:01

  2. core-ci voted on patch set 1 V +1 07/30/25, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82557

  3. Benjamin Franzke commented on patch set 1 07/31/25, 06:33

    ResetPasswordForm.html:63

    Works for me, Chrome autofils new and repeat password field with the same password. ❤️
  4. Benjamin Franzke updated the commit message in patch set 2 V +1 07/31/25, 06:57

  5. Benjamin Franzke commented on patch set 2 07/31/25, 06:58

    ResetPasswordForm.html:63 Reply

    Done
  6. Benjamin Franzke updated the commit message in patch set 3 CR +1 V +1 07/31/25, 07:05

  7. core-ci voted on patch set 2 V +1 07/31/25, 07:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82574

  8. core-ci voted on patch set 3 V +1 07/31/25, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82575

  9. Oliver Klee voted on patch set 3 CR +1 07/31/25, 09:27

  10. Andreas Kienast voted on patch set 3 CR +1 V +1 08/01/25, 09:00

  11. Benjamin Franzke voted on patch set 3 CR +2 V +2 08/01/25, 09:42

  12. Benjamin Franzke merged patch set 4 08/01/25, 09:53