Review main Merged

90220[BUGFIX] Allow multiple search fields per table in FileSearchDemand

Josua Vogel CR +2 V +2 Easy +1 −1 updated 08/11/25, 10:30

Commit message

The method FileSearchDemand->addSearchField() now correctly appends fields to the searchFields array per table, instead of overwriting existing entries.
This enables searching in multiple fields of the same table as intended.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Guido Schmechel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Guido Schmechel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Josua Vogel uploaded patch set 1 08/01/25, 13:55

  2. core-ci voted on patch set 1 V +1 08/01/25, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82636

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 08/01/25, 16:52

  4. Georg Ringer voted on patch set 1 CR +1 V +1 08/06/25, 13:39

  5. Guido Schmechel voted on patch set 1 CR +1 V +1 08/11/25, 10:22

  6. Oli Bartsch voted on patch set 1 CR +2 V +2 08/11/25, 10:30

  7. Oli Bartsch merged patch set 2 08/11/25, 10:30