90294[BUGFIX] Respect system time zone in history module
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Froemken +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Froemken +1
- core-ci +1 CI
Issues 1
Files 2
Review log 3037
Show 912 earlier messages
-
Sebastian Michaelsen uploaded patch set 1 08/08/25, 08:29
-
Sven Liebert commented on patch set 1 CR -1 08/08/25, 08:37
I think we should not hardcode the format to german format. -
core-ci voted on patch set 1 V +1 08/08/25, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83001
-
Sven Liebert commented on patch set 1 08/08/25, 08:54
Reply
Unresolved. -
Sebastian Michaelsen uploaded patch set 2
CR -1V +108/08/25, 08:57 -
Friedemann Altrock voted on patch set 2 CR +1 V +1 08/08/25, 09:03
-
core-ci voted on patch set 2 V +1 08/08/25, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83002
-
Sebastian Michaelsen updated the commit message in patch set 3
CR +1V +108/08/25, 09:22 -
core-ci voted on patch set 3 V +1 08/08/25, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83004
-
Friedemann Altrock voted on patch set 3 CR +1 V +1 08/08/25, 10:13
-
Sebastian Michaelsen commented on patch set 3 08/08/25, 10:19
Reply
Done -
Benni Mack commented on patch set 3 08/08/25, 11:21
ElementHistoryController.php:322wdyt of using DateTimeFactory::createFromTimestamp()?
-
Sebastian Michaelsen uploaded patch set 4
CR +1V +108/08/25, 13:36 -
Sebastian Michaelsen commented on patch set 4 08/08/25, 13:36
ElementHistoryController.php:322ReplyI can do that, but I will still pass it to the DateViewHelper in the same way and don't seem to gain anything from the conversion. -
Friedemann Altrock commented on patch set 4 08/08/25, 13:39
ElementHistoryController.php:323If we create a DateTime object anyway, why not combine the `day` and `time` fields? -
Friedemann Altrock commented on patch set 4 08/08/25, 13:40
ElementHistoryController.php:323ReplyDone, dumb suggestion, as BackendUtility::date does more stuff. -
core-ci voted on patch set 4 V +1 08/08/25, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83021
-
René Pflamm voted on patch set 4 CR +1 08/08/25, 14:56
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 08/09/25, 06:33
-
Sven Liebert voted on patch set 4 CR +1 08/09/25, 06:44
-
Benni Mack uploaded patch set 5
CR +1V +108/12/25, 13:36 -
core-ci voted on patch set 5 V +1 08/12/25, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83205
-
Sebastian Michaelsen voted on patch set 5 CR +1 V +1 08/12/25, 14:55
-
René Pflamm voted on patch set 5 CR +1 08/12/25, 15:01
-
Garvin Hicking voted on patch set 5 CR +1 V +1 08/12/25, 17:55
-
Benni Mack commented on patch set 5 CR -1 08/13/25, 07:34
I'm not sure about this one. Using date() now in "default" (= english) shows US-date format. But ONLY on this place. I wonder if we should either a) only focus on the timezone and handle locale in a separate patch in multiple places for main only b) or roll this out everywhere where BackendUtility::time() is used, and analyze how to switch from US time format to UK time format when using DateTime MEDIUMTIME -
Garvin Hicking commented on patch set 5 CR 0 V 0 08/13/25, 08:44
Reply
Ah good point. `::time` is actually only used in three places (one from this patch, two in FormEngine, but where I figured the 'time' would really be needed due to SQL ops). Hm, thinking about this, maybe we should have a user preference for time format then, and maybe even date format? But that is a large scope. -
Sebastian Michaelsen commented on patch set 5 08/13/25, 09:59
Even though I think having the time format set by the current locale (which already considers the user’s language) is right or at least better than the status quo, I acknowledge that it’s worth a separate discussion and would be okay to only fix the time zone issue. -
Garvin Hicking commented on patch set 5 08/13/25, 11:10
Reply
Yes please, let's reduce the scope (sorry for back and forth). Sadly "english" locale doesnt easily cover US va UK as to a preferrence of times, since we only have "english" as a collective language without further subtypes as a backend language. -
Sebastian Michaelsen uploaded patch set 6
CR +1V +108/18/25, 10:06 -
Sebastian Michaelsen updated the commit message in patch set 7 08/18/25, 10:08
-
core-ci voted on patch set 6 V +1 08/18/25, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83563
-
core-ci voted on patch set 7 V +1 08/18/25, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83564
-
Garvin Hicking voted on patch set 7 CR +1 V +1 08/18/25, 12:43
-
Stefan Froemken commented on patch set 7 CR +1 V +1 08/22/25, 10:30
Perfect! The resulting 'timezone_type' is 3, which can also differentiate between summer and winter time. -
Christian Kuhn voted on patch set 7 CR +2 V +2 08/22/25, 15:15
-
Christian Kuhn merged patch set 8 08/22/25, 15:24