Review main Merged

90367[TASK] Raise enshrined/svg-sanitize dependency to ~0.22

Thomas Hohn CR +2 V +2 Easy +11 −11 updated 08/13/25, 10:05

Commit message

Executed commands:
composer req enshrined/svg-sanitize:~0.22
composer req enshrined/svg-sanitize:~0.22 \
  -d typo3/sysext/core --no-update

Upgrade enshrined/svg-sanitize from ^0.20.0 to ~0.22 to address
https://github.com/advisories/GHSA-22wq-q86m-83fh.

The existing constraint `^0.20.0` is interpreted by Composer as
`>=0.20.0 <0.21.0`, preventing an upgrade to the patched `0.22.x`
series. Changing the constraint to `~0.22` allows versions in the
range `>=0.22.0 <1.0.0`, ensuring future versions are included.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Garvin Hicking +1
    • Albrecht Köhnlein +1
    • Christian Kuhn +1
    • Elias Häußler +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Garvin Hicking +1
    • Albrecht Köhnlein +1
    • Christian Kuhn +1
    • Elias Häußler +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1821

  1. Thomas Hohn uploaded patch set 1 08/13/25, 05:43

  2. core-ci voted on patch set 1 V -1 08/13/25, 05:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83271

  3. Thomas Hohn commented on patch set 1 08/13/25, 06:04

    Maybe you could have a look at the failing test?
  4. Thomas Hohn uploaded patch set 2 V -1 08/13/25, 08:16

  5. core-ci voted on patch set 2 V +1 08/13/25, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83275

  6. Oliver Hader voted on patch set 2 CR -2 08/13/25, 08:33

  7. Oliver Hader commented on patch set 2 08/13/25, 08:34

    Please don't remove test assertions. The reason was the missing `xlink` namespace definition. I'll take care.
  8. Thomas Hohn commented on patch set 2 08/13/25, 08:35

    Reply

    Cool - and thx
  9. Oliver Hader uploaded patch set 3 V +1 08/13/25, 08:41

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  10. core-ci voted on patch set 3 V +1 08/13/25, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83278

  11. Oliver Hader voted on patch set 3 CR 0 08/13/25, 08:49

  12. Thomas Hohn commented on patch set 3 08/13/25, 08:49

    Reply

    @oliver.hader@typo3.org - could you remove the -2 ;-)
  13. Christian Kuhn voted on patch set 3 CR +1 V +1 08/13/25, 08:57

  14. Elias Häußler voted on patch set 3 CR +1 V +1 08/13/25, 08:57

  15. Oliver Hader voted on patch set 3 CR +1 V +1 08/13/25, 08:57

  16. Garvin Hicking voted on patch set 3 CR +1 V +1 08/13/25, 08:58

  17. Albrecht Köhnlein voted on patch set 3 CR +1 V +1 08/13/25, 09:00

  18. Oli Bartsch voted on patch set 3 CR +1 V +1 08/13/25, 09:01

  19. Oliver Hader voted on patch set 3 CR +2 V +2 08/13/25, 09:02

  20. Oliver Klee voted on patch set 3 CR +1 V +1 08/13/25, 09:56

  21. Oliver Hader merged patch set 4 08/13/25, 10:05