Review 12.4 Merged

90372[TASK] Raise enshrined/svg-sanitize dependency to ~0.22

Oliver Hader CR +2 V +2 Easy +11 −11 updated 08/14/25, 11:28

Commit message

Executed commands:
composer req enshrined/svg-sanitize:~0.22
composer req enshrined/svg-sanitize:~0.22 \
  -d typo3/sysext/core --no-update

Upgrade enshrined/svg-sanitize from ^0.20.0 to ~0.22 to address
https://github.com/advisories/GHSA-22wq-q86m-83fh.

The existing constraint `^0.20.0` is interpreted by Composer as
`>=0.20.0 <0.21.0`, preventing an upgrade to the patched `0.22.x`
series. Changing the constraint to `~0.22` allows versions in the
range `>=0.22.0 <1.0.0`, ensuring future versions are included.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Thomas Hohn +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Thomas Hohn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 78

  1. Oliver Hader uploaded patch set 1 08/13/25, 08:49

  2. core-ci voted on patch set 1 V +1 08/13/25, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83280

  3. Thomas Hohn voted on patch set 1 CR +1 V +1 08/13/25, 08:59

  4. Oliver Hader voted on patch set 1 CR +2 V +2 08/13/25, 10:05

  5. Oliver Hader merged patch set 2 08/13/25, 10:05

  6. Jigal van Hemert commented on patch set 2 08/14/25, 10:06

    According to the documentation of composer (see: https://getcomposer.org/doc/articles/versions.md#tilde-version-range- ) ^0.20.0 means: >=0.20.0 <0.20.1 ~0.22 means >=0.22.0 <1.0.0 Do we trust pre-1.0 releases enough to blindingly allow them to be included?
  7. Thomas Hohn commented on patch set 2 08/14/25, 10:38

    Reply

    I would prefer that they would do a proper 1.x releaser. I now that @oliver.hader@typo3.org is one of the contributors - so hopefully he can push it a bit in that direction. That said - it's quite annoying that they had to do an additional release.
  8. Christian Kuhn commented on patch set 2 08/14/25, 11:28