90434[!!!][TASK] Remove FreezableBackendInterface
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
- Sascha Nowak +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
- Sascha Nowak +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Cache/Backend/FileBackend.php+1 −121
- typo3/sysext/core/Classes/Cache/Backend/FreezableBackendInterface.phpdeleted+0 −41
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107310-RemoveFreezableBackendInterface.rstnew+47 −0
- typo3/sysext/core/Tests/Functional/Cache/Backend/FileBackendTest.php+0 −95
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
Review log 1315
-
Sascha Nowak uploaded patch set 1 08/18/25, 16:19
-
core-ci voted on patch set 1 V +1 08/18/25, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83574
-
Simon Schaufelberger commented on patch set 1 CR +1 V +1 08/18/25, 16:31
Great that you found this dead code and thanks for the cleanup! -
Garvin Hicking commented on patch set 1 08/18/25, 18:42
(This is "implemented", more likely through copy-pasta though, in EXT:staticfilecache in its current version) -
Christian Kuhn commented on patch set 1 08/18/25, 18:52
Reply
yeah, but it should be easy to adapt and probably be removed in the extension and still being v13 compatible. -
Christian Kuhn updated the commit message in patch set 2
CR +1V +108/18/25, 18:52 -
Christian Kuhn voted on patch set 2 CR +1 V +1 08/18/25, 18:52
-
Garvin Hicking commented on patch set 2 08/18/25, 18:53
Reply
Sure; I just wanted to comment on the "no real-world" possibility. People probably copied this without knowing about its staleness, but then it still got "implemented". Fair game to remove this. -
core-ci voted on patch set 2 V +1 08/18/25, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83578
-
Sascha Nowak commented on patch set 2 08/18/25, 19:10
Reply
yeah i found that in on staricfilecache too and i will make a pr when this one is merged and remove if there too as this extension seems widely used. -
Sascha Nowak voted on patch set 2 CR +1 V +1 08/18/25, 19:11
-
Oliver Klee voted on patch set 2 CR +1 V +1 08/19/25, 07:33
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 08/19/25, 07:37
-
Stefan Bürk voted on patch set 2 CR +2 V +2 08/19/25, 11:36
-
Stefan Bürk merged patch set 3 08/19/25, 11:36