Review main Abandoned

90463[TASK] Remove obsolete internal annotation from GridColumnItem

TYPO3com CR -1 V 0 Easy +0 −2 updated 08/22/25, 14:33

Commit message

The `@internal` annotation in `GridColumnItem` referenced
instability for TYPO3 v10/v11, but this API has been stable
for several major versions. The annotation is no longer valid
and has been removed.

Review

  • Code review CR -1
    • Christian Kuhn -1
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 1

Review log 610

  1. TYPO3com uploaded patch set 1 08/21/25, 06:13

  2. core-ci voted on patch set 1 V -1 08/21/25, 06:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83699

  3. Georg Ringer commented on patch set 2 V -1 08/21/25, 20:29

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 08/21/25, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83714

  5. Stefan Froemken updated the commit message in patch set 3 V +1 08/22/25, 07:26

  6. core-ci voted on patch set 3 V +1 08/22/25, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83743

  7. Christian Kuhn commented on patch set 3 08/22/25, 13:40

    not sure. we may actually want to keep the internal annotation since the class should receive a refactoring to free __construct and separate service and DO characteristics (the entire fluid based page module suffers from this). This will be much easier to do when the annotation is kept.
  8. Stefan Froemken commented on patch set 3 08/22/25, 13:57

    Reply

    Uih...the good old stateless statement will alway win ;-) Sure: bye bye statefull properties first and THEN we can discuss the internal removal. Good point. Will try to take care of that the next reviews.
  9. Christian Kuhn commented on patch set 3 CR -1 08/22/25, 14:33

    ok. so we'll reject here.
  10. Christian Kuhn abandoned the change 08/22/25, 14:33