90463[TASK] Remove obsolete internal annotation from GridColumnItem
Commit message
Review
-
Code review CR -1
- Christian Kuhn -1
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 1
Review log 610
-
TYPO3com uploaded patch set 1 08/21/25, 06:13
-
core-ci voted on patch set 1 V -1 08/21/25, 06:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83699
-
Georg Ringer commented on patch set 2
V -108/21/25, 20:29Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 08/21/25, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83714
-
Stefan Froemken updated the commit message in patch set 3
V +108/22/25, 07:26 -
core-ci voted on patch set 3 V +1 08/22/25, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83743
-
Christian Kuhn commented on patch set 3 08/22/25, 13:40
not sure. we may actually want to keep the internal annotation since the class should receive a refactoring to free __construct and separate service and DO characteristics (the entire fluid based page module suffers from this). This will be much easier to do when the annotation is kept. -
Stefan Froemken commented on patch set 3 08/22/25, 13:57
Reply
Uih...the good old stateless statement will alway win ;-) Sure: bye bye statefull properties first and THEN we can discuss the internal removal. Good point. Will try to take care of that the next reviews. -
Christian Kuhn commented on patch set 3 CR -1 08/22/25, 14:33
ok. so we'll reject here. -
Christian Kuhn abandoned the change 08/22/25, 14:33