Review main Merged

90500[BUGFIX] Avoid appending multiple referrer-refresh query parameters

Oliver Hader CR +2 V +2 Easy +19 −3 updated 08/30/25, 08:35

Commit message

Currently ReferrerEnforcer simply appends a `referrer-refresh`
query parameter to the existing query. This can result in URIs
like `/typo3/any?referrer-refresh=0&referrer-refresh=123`.

This change ensures the query parameter does only exist once.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Oliver Hader uploaded patch set 1 08/28/25, 18:50

  2. core-ci voted on patch set 1 V +1 08/28/25, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83941

  3. Benni Mack commented on patch set 1 CR +1 V +1 08/29/25, 18:05

    happened to me quite a few times in the past....
  4. Garvin Hicking uploaded patch set 2 CR +1 V +1 08/29/25, 21:04

  5. Garvin Hicking commented on patch set 2 CR +1 V +1 08/29/25, 21:06

    (Added a test to try to verify the parse_str + http_build_query process and fixate that for possible future adaptation)
  6. core-ci voted on patch set 2 V +1 08/29/25, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84017

  7. Oliver Hader commented on patch set 2 08/30/25, 08:28

    Reply

    Thanks for the additional test. I've updated the 13.4 back-port accordingly, adding your tests as well.
  8. Oliver Hader voted on patch set 2 CR +2 V +2 08/30/25, 08:29

  9. Oliver Hader merged patch set 3 08/30/25, 08:35