Review main Merged

90509[BUGFIX] Use array accessors inside \TYPO3\CMS\Core\Type\Map

Oliver Hader CR +2 V +2 Normal +118 −4 updated 08/29/25, 18:23

Commit message

Use array accessors in \TYPO3\CMS\Core\Type\Map when modifying
the internal \SplObjectStorage instance to avoid side-effects
of the PHP implementation.

The invocation of `\SplObjectStorage::current()` is now guarded
by a corresponding `\SplObjectStorage::valid()` check, to avoid
`RuntimeException: Called current() on invalid iterator` when
exceeding the amount of available entries by calling `next()`.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Oliver Hader uploaded patch set 1 08/29/25, 13:07

  2. core-ci voted on patch set 1 V -1 08/29/25, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83987

  3. Oliver Hader uploaded patch set 2 V -1 08/29/25, 13:44

  4. Oliver Hader commented on patch set 2 08/29/25, 13:44

    This change is ready for review.
  5. Oliver Hader uploaded patch set 3 08/29/25, 13:48

  6. Oliver Hader updated the commit message in patch set 4 08/29/25, 13:51

  7. Oliver Hader updated the commit message in patch set 5 08/29/25, 13:51

  8. core-ci voted on patch set 5 V +1 08/29/25, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83994

  9. Benni Mack voted on patch set 5 CR +1 V +1 08/29/25, 14:12

  10. Markus Klein voted on patch set 5 CR +1 V +1 08/29/25, 16:45

  11. Oliver Hader voted on patch set 5 CR +2 V +2 08/29/25, 18:22

  12. Oliver Hader merged patch set 6 08/29/25, 18:23