Review main Merged

90510[TASK] Allow scalar values in \TYPO3\CMS\Core\Type\Map

Oliver Hader CR +2 V +2 Normal +102 −55 updated 10/09/25, 18:27

Commit message

This change allows to use scalar in addition to using only
object values as keys in \TYPO3\CMS\Core\Type\Map.

> $aObject = new \stdClass();
> $bArray = ['b' => 'Array'];
> $cString = 'cString';
>
> $map = new \TYPO3\CMS\Core\Type\Map();
> $map[$aObject] = 'a';
> $map[$bArray] = 'b';
> $map[$cString] = 'c';

The internal \SplObjectStorage wrapper was dropped, since
it did only support object values as keys.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1419

  1. Oliver Hader uploaded patch set 1 08/29/25, 13:44

  2. Oliver Hader rebased onto patch set 2 08/29/25, 13:48

  3. core-ci voted on patch set 2 V -1 08/29/25, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83992

  4. Oliver Hader uploaded patch set 3 V -1 08/29/25, 14:59

  5. core-ci voted on patch set 3 V +1 08/29/25, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83996

  6. Oliver Hader uploaded patch set 4 V +1 08/29/25, 18:33

  7. Oliver Hader commented on patch set 4 08/29/25, 18:33

    This change is ready for review.
  8. Oliver Hader commented on patch set 4 08/29/25, 18:35

    This change is targeted to be back-ported to `12.4` since the recently added new tests in `MapTest` revealed a misbehavior of `SplObjectStorage` in PHP 8.1 when unsetting keys.
  9. Oliver Hader uploaded patch set 5 08/29/25, 18:37

  10. core-ci voted on patch set 5 V +1 08/29/25, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84013

  11. Oliver Hader rebased onto patch set 6 V +1 10/07/25, 19:16

  12. core-ci voted on patch set 6 V +1 10/07/25, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86180

  13. Oliver Hader rebased onto patch set 7 V +1 10/08/25, 13:53

  14. core-ci voted on patch set 7 V +1 10/08/25, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86235

  15. Benni Mack voted on patch set 7 CR +1 V +1 10/09/25, 11:53

  16. Christian Kuhn voted on patch set 7 CR +1 V +1 10/09/25, 15:00

  17. Oliver Hader voted on patch set 7 CR +2 V +2 10/09/25, 18:26

  18. Oliver Hader merged patch set 8 10/09/25, 18:26

  19. Oliver Hader commented on patch set 8 10/09/25, 18:27

    Reply

    Done