Review 12.4 Merged

90517[BUGFIX] Use array accessors inside \TYPO3\CMS\Core\Type\Map

Oliver Hader CR +2 V +2 Normal +131 −4 updated 08/29/25, 18:23

Commit message

Use array accessors in \TYPO3\CMS\Core\Type\Map when modifying
the internal \SplObjectStorage instance to avoid side-effects
of the PHP implementation.

The invocation of `\SplObjectStorage::current()` is now guarded
by a corresponding `\SplObjectStorage::valid()` check, to avoid
`RuntimeException: Called current() on invalid iterator` when
exceeding the amount of available entries by calling `next()`.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 58

  1. Oliver Hader uploaded patch set 1 08/29/25, 16:47

  2. core-ci voted on patch set 1 V -1 08/29/25, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84005

  3. core-ci commented on patch set 1 08/29/25, 17:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84005

  4. Oliver Hader uploaded patch set 2 V -1 08/29/25, 18:15

  5. Oliver Hader commented on patch set 2 08/29/25, 18:16

    MapTest.php:213 Unresolved

    Different behavior in PHP 8.1. Another reason to drop `\SplObjectStorage`
  6. core-ci voted on patch set 2 V +1 08/29/25, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84010

  7. Oliver Hader voted on patch set 2 CR +2 V +2 08/29/25, 18:22

  8. Oliver Hader merged patch set 3 08/29/25, 18:23