Review main Merged

9065[BUGFIX] RTE: Consistent naming for menutabs at "Insert image"

Stefan Neufeind CR +2 V +2 Easy +24 −26 updated 06/03/13, 20:49

Commit message

The various kinds of an image are named like
image, magic, plain and dragdrop. However their
names in the menudefinition are different.

Review

  • Code review CR +2
    • Stanislas Rolland +2
  • Verified V +2
    • Stanislas Rolland +2

Files 1

Review log 15

  1. Stanislas Rolland merged patch set 1 02/17/12, 18:15

  2. Stefan Neufeind commented on patch set 1 02/17/12, 18:15

    I'd like to know your thoughts on this. Could we change the naming? It seems to have been like this for quite some time (that's why the forge-entry refers to an older version). For the few cases where the hook for modification was used it might however matter what the tabnames are so it would be kind of a "BC-break" to change the names in older releases imho. Would it be possible to change (clean) them starting with 4.7?
  3. Stanislas Rolland commented on patch set 2 02/17/12, 18:15

    I don't understand. I don't see any name being changed... And they should not be changed, because they are the documented keys for the RTE configuration. Changing those names may also break hooking scripts, such as DAM.
  4. Stanislas Rolland commented on patch set 2 02/17/12, 18:15

    OK, I see now. I think that hooks would modify the allowedItems list (removing the items they intend to replace) and would normally not need to refer to these internal indices, that do not make much sense indeed. But, to be safe, I think this should be tested with DAM.
  5. Stanislas Rolland uploaded patch set 3 02/17/12, 18:15

  6. Stanislas Rolland commented on patch set 3 V 0 02/17/12, 18:15

    by team member; Looks good to me, approved
  7. Stefan Neufeind uploaded patch set 2 02/17/12, 18:15

  8. Stefan Neufeind commented on patch set 2 02/17/12, 18:15

    @Stanislas: The "external" keys don't change. It's just the internal array-indices that don't seem to make sense at all currently and will be changed to be in line with the parameters that get accessed through the URL, that are in allowedItems and the like. The external names stay the same. As stated, and that's why I must admit it comes with a small BC-break included, is that there is one hook (right after those lines changed here) that gets this $menuDef-array and is able to change it. Theoretically it might be that other extensions already worked around those "broken" array-indices and target one of those tabs. However I expect the "usual" way will be to add additional tabs - and that is still possible the same way it was now. So that's why I think we should not backport the fix but fix it starting with 4.7. But I'd love to hear how others feel about the BC-break. Imho it was "horribly broken" until now :-)
  9. Stefan Neufeind commented on patch set 2 02/17/12, 18:15

    while we already modify those lines apply CGL-fixes (which Georg suggested and some others) as well and access LANG through $GLOBALS['LANG']
  10. Georg Ringer commented on patch set 1 02/17/12, 18:15

    (2 inline comments) naming +1

    class.tx_rtehtmlarea_select_image.php:799

    spaces around ===

    class.tx_rtehtmlarea_select_image.php:800

    $GLOBALS['LANG'] instead of $LANG
  11. Georg Ringer commented on patch set 2 02/17/12, 18:15

    Verified; Looks good to me, but someone else must approve
  12. Philipp Gampe commented on patch set 2 02/17/12, 18:15

    Looks good to me, but someone else must approve The old naming is indeed confusing.
  13. Mr. Jenkins commented on patch set 1 02/17/12, 18:15

  14. Mr. Jenkins commented on patch set 2 02/17/12, 18:15

  15. Mr. Jenkins commented on patch set 3 02/17/12, 18:15