Review main Merged

90717[BUGFIX] Handle versionNumberInFilename also for .mjs files

Markus Klein CR +2 V +2 Easy +1 −1 updated 09/19/25, 18:33

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1517

  1. Markus Klein uploaded patch set 1 09/18/25, 14:02

  2. core-ci voted on patch set 1 V +1 09/18/25, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85121

  3. Simon Praetorius voted on patch set 1 CR +1 V +1 09/18/25, 14:56

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/18/25, 15:06

  5. Garvin Hicking commented on patch set 1 09/18/25, 15:56

    Should we add an "important.rst" to mention this for existing installations that they might want to fix this?
  6. Garvin Hicking commented on patch set 1 09/18/25, 15:57

    Reply

    unresolving
  7. Markus Klein commented on patch set 1 09/18/25, 16:03

    Reply

    IMO not necessary. Things would have failed already before and those people will have added this already.
  8. Garvin Hicking commented on patch set 1 CR +1 V +1 09/18/25, 17:29

    Reply

    Acknowledged
  9. Thomas Hohn voted on patch set 1 CR +1 09/19/25, 11:42

  10. Oli Bartsch commented on patch set 1 09/19/25, 13:54

    Reply

    Based on this argumentation I would like to suggest removing v12 here.
  11. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 09/19/25, 16:55

  12. Garvin Hicking commented on patch set 2 09/19/25, 16:56

    Reply

    Changed to remove 12.4
  13. Garvin Hicking voted on patch set 2 CR +1 V +1 09/19/25, 16:56

  14. core-ci voted on patch set 2 V +1 09/19/25, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85179

  15. Simon Schaufelberger voted on patch set 2 CR +1 V +1 09/19/25, 18:03

  16. Garvin Hicking voted on patch set 2 CR +2 V +2 09/19/25, 18:21

  17. Garvin Hicking merged patch set 3 09/19/25, 18:33