Review TYPO3_4-5 Merged

9073[BUGFIX] TypoLink: absolute urls when installed in subfolder

Susi Moog CR +2 V +2 Easy +10 −1 updated 06/03/13, 20:49

Commit message

If you have TYPO3 installed in a subfolder and a domain
record with that subfolder (localhost/subfolder/ for
example) TYPO3 only generates absolute links in the
frontend.

This is because the typoLink function compares the
HTTP_HOST var with the domainRecord. HTTP_HOST is in
this case "localhost", the domain record has the subfolder
attached. The subfolder needs to be there, as otherwise
t3lib_pageSelect::getDomainStartPage does not find the
start page anymore. typoLink should check for HTTP_HOST +
path of SCRIPT_NAME to determine which domain record
to use (same as getDomainStartPage already does).

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Sebastian Fischer +1
    • Philipp Gampe +1
  • Verified V +2
    • Benni Mack +2
    • Tolleiv Nietsch +1

Files 1

Review log 11

  1. Susi Moog commented on patch set 1 02/09/13, 04:57

    Older branches are already merged.
  2. Tolleiv Nietsch commented on patch set 2 02/09/13, 04:57

    Verified; Looks good to me, approved
  3. Stefan Neufeind commented on patch set 2 02/09/13, 04:57

    Looks good to me, but someone else must approve
    add 6.0
  4. Stefan Neufeind commented on patch set 2 02/09/13, 04:57

    (1 inline comment)
  5. Benni Mack commented on patch set 2 V 0 02/09/13, 04:57

    by team member; Looks good to me, approved Verified and tested with PHP 5.2, works! Please note that this only occurs when: - the domain record doesn't have the flag "Always prepend this domain in links" - the TypoScript option config.typolinkCheckRootline = 1 is set
  6. Benni Mack commented on patch set 2 02/09/13, 04:57

    Verified; Looks good to me, but someone else must approve Verified and tested with PHP 5.2, works! Please note that this only occurs when: - the domain record doesn't have the flag "Always prepend this domain in links" - the TypoScript option config.typolinkCheckRootline = 1 is set
  7. Susi Moog uploaded patch set 2 02/09/13, 04:57

  8. Sebastian Fischer commented on patch set 2 02/09/13, 04:57

    Looks good to me, but someone else must approve
  9. Philipp Gampe commented on patch set 1 02/09/13, 04:57

    I would prefer that you didn't submit this Submodule pointers are included. Is this still needed? Did you push this to the upper branches already?
  10. Philipp Gampe commented on patch set 2 02/09/13, 04:57

    Looks good to me, but someone else must approve Same as master (I have reviewed that one).
  11. Benni Mack merged patch set 3 02/09/13, 04:57