Review TYPO3_4-6 Merged

9074[BUGFIX] TypoLink: absolute urls when installed in subfolder

Susi Moog CR +2 V +2 Easy +10 −1 updated 06/03/13, 20:49

Commit message

If you have TYPO3 installed in a subfolder and a domain
record with that subfolder (localhost/subfolder/ for
example) TYPO3 only generates absolute links in the
frontend.

This is because the typoLink function compares the
HTTP_HOST var with the domainRecord. HTTP_HOST is in
this case "localhost", the domain record has the subfolder
attached. The subfolder needs to be there, as otherwise
t3lib_pageSelect::getDomainStartPage does not find the
start page anymore. typoLink should check for HTTP_HOST +
path of SCRIPT_NAME to determine which domain record
to use (same as getDomainStartPage already does).

Review

  • Code review CR +2
    • Xavier Perseguers +2
  • Verified V +2
    • Xavier Perseguers +2

Files 1

Review log 3

  1. Susi Moog uploaded patch set 2 03/06/12, 08:49

  2. Xavier Perseguers commented on patch set 2 V 0 03/06/12, 08:49

    by team member; Looks good to me, approved Backport from master
  3. Xavier Perseguers merged patch set 2 03/06/12, 08:49