9084[FEATURE] Add search for alias as option to the pagetree filter
Commit message
Review
-
Code review CR +2
- Philipp Gampe +2
- Sebastian Michaelsen +1
-
Verified V +2
- Philipp Gampe +2
- Sebastian Michaelsen +1
Issues 1
Files 1
Review log 28
Show 3 earlier messages
-
Stefan Neufeind commented on patch set 2 05/27/13, 17:19
(1 inline comment) Great. In general I like the idea. Can't judge about the UX. But it would be great if those small things could be sorted out. Technically imho we're "almost there" *sigh*6.0 meanwhile -
Stefan Neufeind commented on patch set 2 05/27/13, 17:19
Since it can be argued that the user-experience when searching for an alias (and there might be nothing clear to highlight easily etc.): What if we simply allow searching by the full frontend-URL? For searching by full frontend-URL see: http://forge.typo3.org/issues/39701 -
Stefan Galinski commented on patch set 2 05/27/13, 17:19
I just want to remind that I see UX problems if you filter by other fields than title/navTitle and uid, because the filtering string can't be always highglighted inside the matching pages and this possibly confuses the usual users. Maybe the alias matches can be completely highlighted like the uid matches, because this information is inside the small info tooltip? So I don't think that the filtering in all configured search fields is a good idea. Should this issue be moved to the UX tracker for feedback from the experts? :-)
-
Steffen Gebert commented on patch set 2 05/27/13, 17:19
I would prefer that you didn't submit this Why not search for alias by default? I'm against the new option. -
Steffen Ritter commented on patch set 2 05/27/13, 17:19
HI Thomas, we already do have options to control "how a table is searched" on fulltext search. I would like to see that used, so all searches in BE for table pages stay conistent... -
Steffen Ritter commented on patch set 2 05/27/13, 17:19
I would prefer that you didn't submit this I would say no rush with this for 4.7 anymore please! -
Philipp Gampe commented on patch set 2 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve Works for me. -
Simon Schaufelberger commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve -
Simon Schaufelberger commented on patch set 2 05/27/13, 17:19
steffen see: https://review.typo3.org/8963. performance... -
Simon Schaufelberger commented on patch set 2 05/27/13, 17:19
stupid regex is wrong in gerrit: https://review.typo3.org/8963 -
Felix Kopp commented on patch set 2 05/27/13, 17:19
I don't see the requirement of an option. Tree search should just also query these fields. -
Thomas Layh commented on patch set 2 05/27/13, 17:19
Hi Steffen, sounds good to me. But shouldn't we then move the option for the search in the navTitle as well? Or did I misunderstood you? -
Thomas Layh uploaded patch set 2 05/27/13, 17:19
-
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3307/ : FAILURE -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3308/ : SUCCESS -
Alexander Opitz commented on patch set 2 07/03/13, 07:31
@Felix The option was implemented as requested: https://review.typo3.org/8963 -
Alexander Opitz uploaded patch set 3 07/03/13, 07:48
-
Mr. Jenkins commented on patch set 3 07/03/13, 07:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9327/ : SUCCESS -
Alexander Opitz uploaded patch set 4 07/03/13, 07:49
-
Mr. Jenkins commented on patch set 4 07/03/13, 07:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9328/ : SUCCESS -
Susi Moog commented on patch set 4 07/04/13, 13:42
DataProvider.php:436why change the sql AND to &&? -
Alexander Opitz uploaded patch set 5 07/04/13, 14:15
-
Mr. Jenkins commented on patch set 5 07/04/13, 14:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9353/ : SUCCESS -
Alexander Opitz commented on patch set 4 07/04/13, 14:16
DataProvider.php:436ReplyThere was a merge conflict while rebasing, took the false one. :-) -
Philipp Gampe voted on patch set 5 V +1 CR +1 07/05/13, 08:17
-
Sebastian Michaelsen voted on patch set 5 V +1 CR +1 07/05/13, 08:19
-
Philipp Gampe commented on patch set 5 V +2 CR +2 07/05/13, 08:24
Doc issue has been created. -
Philipp Gampe merged patch set 6 07/05/13, 08:24