9085[TASK] Move tslib_content classes to own files
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Tolleiv Nietsch +1
- Philipp Gampe +1
-
Verified V +2
- Susi Moog +2
- Tolleiv Nietsch +1
Issues 1
Files 5
Review log 7
-
Susi Moog merged patch set 1 02/18/12, 23:06
-
Tolleiv Nietsch commented on patch set 1 02/18/12, 23:06
Verified; Looks good to me, but someone else must approve -
Markus Klein commented on patch set 1 02/18/12, 23:06
(3 inline comments) Please answer my comments.ext_autoload.php:10Is it on purpose that you didn't use the camelCase names for the classes here? tableOffset, controlTableclass.tslib_controltable.php:186controlTable uppercase here too?class.tslib_tableoffset.php:120tableOffset? -
Susi Moog commented on patch set 1 V 0 02/18/12, 23:06
by team member; Looks good to me, approved -
Christian Kuhn commented on patch set 1 02/18/12, 23:06
(3 inline comments) done.ext_autoload.php:10ReplyYes, keys in ext_autoload must be lower camel case.class.tslib_controltable.php:186ReplyShould be identical to filename, and filename is lowercase, like all other files in this area.class.tslib_tableoffset.php:120Replydito to other comment -
Philipp Gampe commented on patch set 1 02/18/12, 23:06
Looks good to me, but someone else must approve I had a quick look at the changes. Did you touche a lot of lines? I tried to quick moved lines, but this only suppressed like 100 of 800 lines from the patch. Anyway the change look strait forward. -
Mr. Jenkins commented on patch set 1 02/18/12, 23:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3309/ : SUCCESS