Review main Merged

9085[TASK] Move tslib_content classes to own files

Christian Kuhn CR +2 V +2 Hard +459 −385 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Susi Moog +2
    • Tolleiv Nietsch +1
    • Philipp Gampe +1
  • Verified V +2
    • Susi Moog +2
    • Tolleiv Nietsch +1

Issues 1

Files 5

Review log 7

  1. Susi Moog merged patch set 1 02/18/12, 23:06

  2. Tolleiv Nietsch commented on patch set 1 02/18/12, 23:06

    Verified; Looks good to me, but someone else must approve
  3. Markus Klein commented on patch set 1 02/18/12, 23:06

    (3 inline comments) Please answer my comments.

    ext_autoload.php:10

    Is it on purpose that you didn't use the camelCase names for the classes here? tableOffset, controlTable

    class.tslib_controltable.php:186

    controlTable uppercase here too?

    class.tslib_tableoffset.php:120

    tableOffset?
  4. Susi Moog commented on patch set 1 V 0 02/18/12, 23:06

    by team member; Looks good to me, approved
  5. Christian Kuhn commented on patch set 1 02/18/12, 23:06

    (3 inline comments) done.

    ext_autoload.php:10 Reply

    Yes, keys in ext_autoload must be lower camel case.

    class.tslib_controltable.php:186 Reply

    Should be identical to filename, and filename is lowercase, like all other files in this area.

    class.tslib_tableoffset.php:120 Reply

    dito to other comment
  6. Philipp Gampe commented on patch set 1 02/18/12, 23:06

    Looks good to me, but someone else must approve I had a quick look at the changes. Did you touche a lot of lines? I tried to quick moved lines, but this only suppressed like 100 of 800 lines from the patch. Anyway the change look strait forward.
  7. Mr. Jenkins commented on patch set 1 02/18/12, 23:06