Review 12.4 Merged

90875[BUGFIX] Fix type error on empty $be_user_data['realName']

Mikel Wohlschlegel CR +2 V +2 Easy +1 −1 updated 10/03/25, 07:44

Commit message

When the `realName` field is disabled in User Settings, the SetupModuleController passes NULL to ContextData, which causes a TypeError in PHP 8+. This patch uses the DB value as fallback.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Mikel Wohlschlegel uploaded patch set 1 10/02/25, 09:59

  2. core-ci voted on patch set 1 V -1 10/02/25, 10:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85895

  3. Mikel Wohlschlegel commented on patch set 1 10/02/25, 10:29

    recheck
  4. core-ci voted on patch set 1 V +1 10/02/25, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85895

  5. Garvin Hicking updated the commit message in patch set 2 V +1 10/02/25, 11:21

  6. Garvin Hicking commented on patch set 2 CR +1 V +1 10/02/25, 11:21

    Thanks, good catch!
  7. core-ci voted on patch set 2 V +1 10/02/25, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85910

  8. Garvin Hicking commented on patch set 2 10/02/25, 11:34

    Reply

    Done
  9. Stefan Bürk voted on patch set 2 CR +2 V +2 10/02/25, 21:01

  10. Stefan Bürk commented on patch set 2 CR 0 V 0 10/02/25, 21:08

    Usually patches are provided for the newes branch fist (main) and we backport things and voting happens on the main change. That means moving a change first to main. Created now main and 13.4 as "up-ports" and voting should be done on https://review.typo3.org/c/Packages/TYPO3.CMS/+/90885 to keep the chain how it should be and looking later into the chain does not confuse peopls seeing only one core merger +2 on a main-branch change not expected. @garvin@hick.ing please revote/check main branch change.
  11. Stefan Bürk wrote 10/02/25, 21:31

    Removed reviewer Stefan Bürk.
  12. Stefan Bürk voted on patch set 2 CR +2 V +2 10/03/25, 07:43

  13. Stefan Bürk merged patch set 3 10/03/25, 07:43

  14. Stefan Bürk commented on patch set 3 10/03/25, 07:44

    Reply

    Done