Review main Merged

90885[BUGFIX] Fix type error on empty $be_user_data['realName']

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 10/03/25, 07:43

Commit message

When the `realName` field is disabled in User Settings, the SetupModuleController passes NULL to ContextData, which causes a TypeError in PHP 8+. This patch uses the DB value as fallback.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Stefan Bürk commented on patch set 1 10/02/25, 21:03

    Cherry Picked from branch 13.4.
  2. core-ci voted on patch set 1 V +1 10/02/25, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85940

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 10/02/25, 21:14

  4. Stefan Bürk commented on patch set 1 10/02/25, 21:18

    Note voted on this after doing a "up-port" of the change from contributor @mw@con-version.de pushed against 12.4, not changing anything and not my change. So legit to vote "on" it.
  5. Garvin Hicking voted on patch set 1 CR +1 V +1 10/03/25, 00:36

  6. Stefan Bürk voted on patch set 1 CR +2 V +2 10/03/25, 07:43

  7. Stefan Bürk merged patch set 2 10/03/25, 07:43