Review main Merged

90892[DOCS] Do not override existing scheduler configurations

TYPO3com CR +2 V +2 Easy +16 −24 updated 10/04/25, 13:48

Commit message

The example as it is currently in here would override all configuration
made by other extensions, including EXT:scheduler itself.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1623

  1. TYPO3com uploaded patch set 1 10/04/25, 06:01

  2. Lina Wolf commented on patch set 1 10/04/25, 06:02

    Watching
  3. Lina Wolf updated the commit message in patch set 2 10/04/25, 06:02

  4. core-ci voted on patch set 1 V +1 10/04/25, 06:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85974

  5. core-ci voted on patch set 2 V +1 10/04/25, 06:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85975

  6. Chris Müller commented on patch set 2 10/04/25, 06:43

    Deprecation-107550-TableGarbageCollectionTaskConfigurationViaGlobals.rst:45

    The example here should also be adjusted as it overrides the tables array like previously below.
  7. Lina Wolf commented on patch set 2 10/04/25, 06:52

    Deprecation-107550-TableGarbageCollectionTaskConfigurationViaGlobals.rst:45 Reply

    This is a "Before" example...
  8. Chris Müller commented on patch set 2 10/04/25, 07:09

    Deprecation-107550-TableGarbageCollectionTaskConfigurationViaGlobals.rst:45 Reply

    Also the before has that flaw. The docs provide a correct example, IMHO the changelog should describe that also that way: https://docs.typo3.org/c/typo3/cms-scheduler/main/en-us/Installation/BaseTasks/Index.html#table-garbage-collection-task-example
  9. Lina Wolf commented on patch set 2 10/04/25, 07:17

    Deprecation-107550-TableGarbageCollectionTaskConfigurationViaGlobals.rst:45 Reply

    Feel free to change it in this change or in a follow up. Before examples by design are not best practices
  10. Oli Bartsch commented on patch set 2 10/04/25, 08:56

    Deprecation-107550-TableGarbageCollectionTaskConfigurationViaGlobals.rst:45 Reply

    I suggest to adjust before and after. Additionally the same example is in typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-107562-IpAnonymizationTaskConfigurationViaGlobals.rst
  11. Chris Müller uploaded patch set 3 V +1 10/04/25, 09:53

  12. Chris Müller commented on patch set 3 10/04/25, 09:54

    Deprecation-107550-TableGarbageCollectionTaskConfigurationViaGlobals.rst:45 Reply

    Done
  13. Chris Müller uploaded patch set 4 10/04/25, 09:55

  14. Chris Müller updated the commit message in patch set 5 10/04/25, 09:56

  15. core-ci voted on patch set 3 V +1 10/04/25, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86002

  16. core-ci voted on patch set 5 V +1 10/04/25, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86004

  17. core-ci voted on patch set 4 V +1 10/04/25, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86003

  18. Chris Müller voted on patch set 5 CR +1 V +1 10/04/25, 10:11

  19. Oli Bartsch uploaded patch set 6 CR +1 V +1 10/04/25, 11:53

  20. Oli Bartsch voted on patch set 6 CR +1 V +1 10/04/25, 11:58

  21. core-ci voted on patch set 6 V +1 10/04/25, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86008

  22. Garvin Hicking voted on patch set 6 CR +2 V +2 10/04/25, 13:48

  23. Garvin Hicking merged patch set 7 10/04/25, 13:48