90892[DOCS] Do not override existing scheduler configurations
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1623
-
TYPO3com uploaded patch set 1 10/04/25, 06:01
-
Lina Wolf commented on patch set 1 10/04/25, 06:02
Watching -
Lina Wolf updated the commit message in patch set 2 10/04/25, 06:02
-
core-ci voted on patch set 1 V +1 10/04/25, 06:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85974
-
core-ci voted on patch set 2 V +1 10/04/25, 06:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85975
-
Chris Müller commented on patch set 2 10/04/25, 06:43
Deprecation-107550-TableGarbageCollectionTaskConfigurationViaGlobals.rst:45The example here should also be adjusted as it overrides the tables array like previously below. -
Lina Wolf commented on patch set 2 10/04/25, 06:52
Deprecation-107550-TableGarbageCollectionTaskConfigurationViaGlobals.rst:45ReplyThis is a "Before" example... -
Chris Müller commented on patch set 2 10/04/25, 07:09
Deprecation-107550-TableGarbageCollectionTaskConfigurationViaGlobals.rst:45ReplyAlso the before has that flaw. The docs provide a correct example, IMHO the changelog should describe that also that way: https://docs.typo3.org/c/typo3/cms-scheduler/main/en-us/Installation/BaseTasks/Index.html#table-garbage-collection-task-example -
Lina Wolf commented on patch set 2 10/04/25, 07:17
Deprecation-107550-TableGarbageCollectionTaskConfigurationViaGlobals.rst:45ReplyFeel free to change it in this change or in a follow up. Before examples by design are not best practices -
Oli Bartsch commented on patch set 2 10/04/25, 08:56
Deprecation-107550-TableGarbageCollectionTaskConfigurationViaGlobals.rst:45ReplyI suggest to adjust before and after. Additionally the same example is in typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-107562-IpAnonymizationTaskConfigurationViaGlobals.rst -
Chris Müller uploaded patch set 3
V +110/04/25, 09:53 -
Chris Müller commented on patch set 3 10/04/25, 09:54
Deprecation-107550-TableGarbageCollectionTaskConfigurationViaGlobals.rst:45ReplyDone -
Chris Müller uploaded patch set 4 10/04/25, 09:55
-
Chris Müller updated the commit message in patch set 5 10/04/25, 09:56
-
core-ci voted on patch set 3 V +1 10/04/25, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86002
-
core-ci voted on patch set 5 V +1 10/04/25, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86004
-
core-ci voted on patch set 4 V +1 10/04/25, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86003
-
Chris Müller voted on patch set 5 CR +1 V +1 10/04/25, 10:11
-
Oli Bartsch uploaded patch set 6
CR +1V +110/04/25, 11:53 -
Oli Bartsch voted on patch set 6 CR +1 V +1 10/04/25, 11:58
-
core-ci voted on patch set 6 V +1 10/04/25, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86008
-
Garvin Hicking voted on patch set 6 CR +2 V +2 10/04/25, 13:48
-
Garvin Hicking merged patch set 7 10/04/25, 13:48