Review main Merged

90913[BUGFIX] Avoid storing FE "last changed" in register

Christian Kuhn CR +2 V +2 Normal +57 −20 updated 10/07/25, 10:19

Commit message

The "last updated" mechanism in FE is and has always been
flawed. It is however hard to substitute with something
more reliable.

The patch fixes a single long standing issue and documents
the other shortcomings. Storing "SYS_LASTCHANGED" in the
FE "register" cripples the approach of gathering the
"highest" timestamp from content elements: The register is
a stack, an updated value on the stack vanishes on pop.
When the "final" value is used after rendering all content
elements, any changed "last update" values from content
elements are usually gone due to RESTORE_REGISTER cObj calls.
The patch thus moves the "last updated" information gathering
away from "register" and stores it as separated information
in the recently established "frontent.page.parts" request
attribute. TS data/getText key "register:SYS_LASTCHANGED" is
kept as b/w compat layer to not break hard to debug FE TS.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 1117

  1. Christian Kuhn uploaded patch set 1 10/06/25, 15:30

  2. core-ci voted on patch set 1 V -1 10/06/25, 15:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86078

  3. Christian Kuhn uploaded patch set 2 V -1 10/06/25, 15:50

  4. Christian Kuhn uploaded patch set 3 10/06/25, 15:53

  5. core-ci voted on patch set 3 V +1 10/06/25, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86082

  6. core-ci voted on patch set 2 V -1 10/06/25, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86081

  7. Christian Kuhn updated the commit message in patch set 4 V +1 10/06/25, 16:08

  8. Christian Kuhn updated the commit message in patch set 5 10/06/25, 16:09

  9. Christian Kuhn uploaded patch set 6 10/06/25, 16:12

  10. core-ci voted on patch set 4 V +1 10/06/25, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86084

  11. core-ci voted on patch set 5 V +1 10/06/25, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86085

  12. core-ci voted on patch set 6 V +1 10/06/25, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86086

  13. Garvin Hicking commented on patch set 6 CR +1 V +1 10/06/25, 18:26

    Nice, the TSFE removal improves this mess a bit 😄
  14. Stefan Bürk voted on patch set 6 CR +1 10/07/25, 09:24

  15. Stefan Bürk voted on patch set 6 V +1 10/07/25, 09:34

  16. Christian Kuhn voted on patch set 6 CR +2 V +2 10/07/25, 10:19

  17. Christian Kuhn merged patch set 7 10/07/25, 10:19