Review main Abandoned

90983[BUGFIX] Add spacing to language names in Install Tool > Manage Language Packs

Georg Ringer CR +1 V +1 Easy +4 −3 updated 03/12/26, 06:34

Commit message

Improve the rows of the table to download translations in the Install Tool
by using a separate cell for buttons and label.

Review

  • Code review CR +1
    • Josef Glatz +1
    • Garvin Hicking +1
    • Josua Vogel +1
  • Verified V +1
    • Josef Glatz +1
    • Garvin Hicking +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1013

  1. Georg Ringer uploaded patch set 1 10/09/25, 18:20

  2. Georg Ringer commented on patch set 1 10/09/25, 18:21

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/09/25, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86335

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 10/10/25, 08:39

    Not sure if that is the best option, we could also just add a `<span>` around the name and leave the table intact, or maybe even `btn-group` would need context-spacing via CSS? @benjamin.kott@outlook.com? But it definitely looks wrong now and we could do something, so this one is better than leaving it like it is 😄
  5. Josef Glatz voted on patch set 1 CR +1 V +1 10/10/25, 08:47

  6. Georg Ringer uploaded patch set 2 CR +1 V +1 12/29/25, 17:42

  7. core-ci voted on patch set 2 V +1 12/29/25, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92783

  8. Georg Ringer uploaded patch set 3 V +1 03/10/26, 03:53

  9. core-ci voted on patch set 3 V +1 03/10/26, 04:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97631

  10. Garvin Hicking commented on patch set 3 CR +1 V +1 03/10/26, 05:52

    Reply

    I'm resolving this. It'll be fine or adapated. ;)
  11. Josef Glatz voted on patch set 3 CR +1 V +1 03/10/26, 08:59

  12. Josua Vogel voted on patch set 3 CR +1 V +1 03/11/26, 20:29

  13. Georg Ringer abandoned the change 03/12/26, 06:34