Review main Merged

91009[DOCS] cache:warmup help text: warn about PHP version mismatch

Lina Wolf CR +2 V +2 Easy +12 −1 updated 11/11/25, 09:15

Commit message

Mismatching PHP versions might break deployment scenarios. Warn about this in the
commands help text, displayed when calling

ddev typo3 cache:warmup -h

The change will be displayed as warning box
at https://docs.typo3.org/permalink/t3coreapi:console-command-cache-warmup automatically.

We already have a warning of this format in the setup command for example: https://docs.typo3.org/permalink/t3coreapi:console-command-setup

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Josef Glatz +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1214

  1. Lina Wolf uploaded patch set 1 10/11/25, 06:20

  2. core-ci voted on patch set 1 V +1 10/11/25, 06:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86454

  3. Garvin Hicking commented on patch set 1 10/11/25, 08:46

    CacheWarmupCommand.php:58

    Theoretically at some point TYPO3 might support 8.5 and 9.0 - I would not specifically mention "minor version". Also maybe phrase it less "does not work". Please note, cache warmup via CLI is fixed to the PHP version currently used in CLI (%s). If the web version differs, the warmed-up cache might not be used and will be rebuilt for %s we could emit the CLI PHP version?
  4. Lina Wolf commented on patch set 2 V +1 10/11/25, 10:38

    Published edit on patch set 1.
  5. Lina Wolf commented on patch set 2 10/11/25, 10:40

    CacheWarmupCommand.php:58 Reply

    Good point, I rephrased the help text. I think command help texts should be static as they can be displayed in different context like a JSON output to be displayed in the docs. We can tell ppl to use php --version, however a developer running CLI scripts should know about this...
  6. core-ci voted on patch set 2 V +1 10/11/25, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86461

  7. Lina Wolf commented on patch set 2 10/13/25, 12:54

    CacheWarmupCommand.php:58 Reply

    Done
  8. Garvin Hicking voted on patch set 2 CR +1 V +1 10/13/25, 15:06

  9. Josef Glatz commented on patch set 2 10/13/25, 20:08

    There is a pending review for DI cache stuff which generates a dedicated php version version based on major and minor php version. Is this something we should consider think of for cache:warmup?
  10. Garvin Hicking commented on patch set 2 10/13/25, 20:41

    Reply

    The pending patch would not affect the warmed up cache being unusable for differing PHP versions - it would just ensure that no PHP error appears. So IMO this patch would apply independently from that patch...
  11. Lina Wolf commented on patch set 2 10/22/25, 13:34

    Reply

    Acknowledged
  12. Josef Glatz voted on patch set 2 CR +1 V +1 11/11/25, 09:03

  13. Garvin Hicking voted on patch set 2 CR +2 V +2 11/11/25, 09:14

  14. Garvin Hicking merged patch set 3 11/11/25, 09:15