91009[DOCS] cache:warmup help text: warn about PHP version mismatch
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Josef Glatz +1
-
Verified V +2 Done
- Garvin Hicking +2
- Josef Glatz +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1214
-
Lina Wolf uploaded patch set 1 10/11/25, 06:20
-
core-ci voted on patch set 1 V +1 10/11/25, 06:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86454
-
Garvin Hicking commented on patch set 1 10/11/25, 08:46
-
Lina Wolf commented on patch set 2
V +110/11/25, 10:38Published edit on patch set 1. -
Lina Wolf commented on patch set 2 10/11/25, 10:40
CacheWarmupCommand.php:58ReplyGood point, I rephrased the help text. I think command help texts should be static as they can be displayed in different context like a JSON output to be displayed in the docs. We can tell ppl to use php --version, however a developer running CLI scripts should know about this... -
core-ci voted on patch set 2 V +1 10/11/25, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86461
-
Lina Wolf commented on patch set 2 10/13/25, 12:54
CacheWarmupCommand.php:58ReplyDone -
Garvin Hicking voted on patch set 2 CR +1 V +1 10/13/25, 15:06
-
Josef Glatz commented on patch set 2 10/13/25, 20:08
There is a pending review for DI cache stuff which generates a dedicated php version version based on major and minor php version. Is this something we should consider think of for cache:warmup? -
Garvin Hicking commented on patch set 2 10/13/25, 20:41
Reply
The pending patch would not affect the warmed up cache being unusable for differing PHP versions - it would just ensure that no PHP error appears. So IMO this patch would apply independently from that patch... -
Lina Wolf commented on patch set 2 10/22/25, 13:34
Reply
Acknowledged -
Josef Glatz voted on patch set 2 CR +1 V +1 11/11/25, 09:03
-
Garvin Hicking voted on patch set 2 CR +2 V +2 11/11/25, 09:14
-
Garvin Hicking merged patch set 3 11/11/25, 09:15
CacheWarmupCommand.php:58