91027[FEATURE] Add PSR-14 for record retrieval in DatabaseRecordLinkBuilder
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107679-IntroducePSR14RetrieveRecordForLinkBuilderEvent.rstnew+75 −0
- typo3/sysext/frontend/Classes/Event/BeforeDatabaseRecordLinkResolvedEvent.phpnew+44 −0
- typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php4+39 −23
- typo3/sysext/frontend/Tests/Functional/Typolink/DatabaseRecordLinkBuilderTest.phpnew+171 −0
- typo3/sysext/frontend/Tests/Unit/Typolink/DatabaseRecordLinkBuilderTest.php+1 −0
Review log 2332
Show 57 earlier messages
-
Francois Suter uploaded patch set 1 10/13/25, 11:14
-
core-ci voted on patch set 1 V -1 10/13/25, 11:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86537
-
Francois Suter uploaded patch set 2
V -110/13/25, 14:12 -
core-ci voted on patch set 2 V +1 10/13/25, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86547
-
Benni Mack commented on patch set 2 10/13/25, 14:50
-
Francois Suter commented on patch set 2 10/13/25, 14:55
Thanks for the quick feedback. Will refactor.DatabaseRecordLinkBuilder.php:78ReplyAcknowledged -
Stefan Bürk commented on patch set 2 10/13/25, 15:22
Sorry, in the current form this does not make any sense ... the event does not hold any context for a event listener to return a "meaningfull" record. Based on what should the event listener now which record to return and for which id ? Even moving the record retrival into a dedicated method and dispatching the event there needs to provide proper context, otherwise the whole event is use-less. Or do I miss something ? To precise .. how should a event listener knwo to return for example `tx_news_domain_model_news UID: 1234` as record or `page UID: 987`. At least table name and linkDetails UID needs to be passed, if not $linkDetails or even more the whole $linkHandlerConfiguration.
-
Francois Suter commented on patch set 2 10/13/25, 19:45
Reply
Doh, I feel absolutely silly. There was indeed a little voice nagging at me, saying that the event class looked ridiculously naked, but I must have been very distracted. I'll fix that of course! -
Francois Suter uploaded patch set 3
V +110/14/25, 06:41 -
Francois Suter commented on patch set 3 10/14/25, 06:43
Reply
Done -
core-ci voted on patch set 3 V -1 10/14/25, 06:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86599
-
Francois Suter uploaded patch set 4
V -110/14/25, 06:56 -
core-ci voted on patch set 4 V +1 10/14/25, 07:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86600
-
Francois Suter uploaded patch set 5
V +110/27/25, 09:42 -
core-ci voted on patch set 5 V -1 10/27/25, 09:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87629
-
Oli Bartsch uploaded patch set 6
V -110/27/25, 11:36 -
core-ci voted on patch set 6 V -1 10/27/25, 11:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87639
-
Oli Bartsch uploaded patch set 7
V -110/27/25, 11:47 -
core-ci voted on patch set 7 V +1 10/27/25, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87640
-
Oli Bartsch voted on patch set 7 CR +2 V +2 10/27/25, 12:01
-
Oli Bartsch voted on patch set 7 CR +1 V +1 10/27/25, 12:38
-
Benni Mack commented on patch set 7 10/27/25, 15:08
DatabaseRecordLinkBuilder.php:79we need the request object here as well. -
Francois Suter uploaded patch set 8
CR +1V +110/27/25, 15:55 -
Francois Suter commented on patch set 8 10/27/25, 15:55
DatabaseRecordLinkBuilder.php:79ReplyAdded in the new patchset -
core-ci voted on patch set 8 V +1 10/27/25, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87676
-
Jochen Roth commented on patch set 8 10/27/25, 16:37
> done -
Benni Mack updated the commit message in patch set 9
V +110/27/25, 16:45 -
Benni Mack commented on patch set 9 10/27/25, 16:46
Reply
Done -
Benni Mack voted on patch set 9 CR +1 V +1 10/27/25, 16:46
-
Oli Bartsch voted on patch set 9 CR +2 V +2 10/27/25, 16:48
-
Oli Bartsch merged patch set 10 10/27/25, 16:48
-
core-ci voted on patch set 9 V +1 10/27/25, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87687
DatabaseRecordLinkBuilder.php:78