Review main Merged

91081[BUGFIX] Add typecast to value checked in DataHandler

Georg Ringer CR +2 V +2 Easy +2 −2 updated 03/04/26, 09:15

Commit message

The method `checkValue_SW` receives the argument `$value` (which can be
`null`) and hands it to `checkValueForInline`.

Inside, the cast is required as it is used at `GeneralUtility::trimExplode`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Lina Wolf +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1622

  1. Georg Ringer uploaded patch set 1 10/15/25, 14:50

  2. Georg Ringer commented on patch set 1 10/15/25, 14:51

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/15/25, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86735

  4. Oliver Klee updated the commit message in patch set 2 V +1 10/15/25, 15:06

  5. Oliver Klee updated the commit message in patch set 3 10/15/25, 15:06

  6. Oli Bartsch commented on patch set 3 10/15/25, 15:10

    DataHandler.php:2500

    I wonder why we do not apply the type cast on calling the method, so we can enforce a string in the parameter declaration.
  7. core-ci voted on patch set 2 V +1 10/15/25, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86739

  8. core-ci voted on patch set 3 V +1 10/15/25, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86740

  9. Stefan Bürk commented on patch set 3 10/15/25, 21:03

    DataHandler.php:2500 Reply

    Thought the same. Additionally, it does not make sense to check a empty string (or null) and do the whole processing or checks to do the further checks and working below and could be an early return ... or not ?
  10. Georg Ringer rebased onto patch set 4 V +1 12/29/25, 16:49

  11. Georg Ringer uploaded patch set 5 12/29/25, 16:49

  12. core-ci voted on patch set 4 V +1 12/29/25, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92777

  13. core-ci voted on patch set 5 V +1 12/29/25, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92778

  14. Benni Mack commented on patch set 5 01/23/26, 14:46

    DataHandler.php:2500 Reply

    I personally would not add type cast to the methods, as it is a bugfix (to v13) ?
  15. Georg Ringer uploaded patch set 6 V +1 03/02/26, 19:33

  16. core-ci voted on patch set 6 V +1 03/02/26, 19:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97133

  17. Lina Wolf commented on patch set 6 03/04/26, 06:00

    DataHandler.php:2500 Reply

    The typecast on the method call would work also in TYPO3 13. and it would stay in the current pattern as all other calls there are also cast to string.
  18. Lina Wolf commented on patch set 6 V +1 03/04/26, 06:01

    This solves the issue for me. I am neutral on the code review, I would opt for calling the method with the declared type only, however this fix is fine to me as well
  19. Oliver Klee voted on patch set 6 CR +1 03/04/26, 08:09

  20. Christian Kuhn commented on patch set 6 CR +1 V +1 03/04/26, 08:51

    DataHandler.php:2500 Reply

    i'd think the change is fine in set 6 variant with explicit cast when calling the method and not changing the method signature. this should be good as bugfix.
  21. Christian Kuhn voted on patch set 6 CR +2 V +2 03/04/26, 09:15

  22. Christian Kuhn merged patch set 7 03/04/26, 09:15