Review main Merged

91102[TASK] Add visual labels to backend login related form input fields

Elias Häußler CR +2 V +2 Normal +67 −70 updated 10/27/25, 18:56

Commit message

In order to make the backend login forms accessible, all input fields
are now covered by visual labels. With this change, all login related
forms (login, password forget, password reset, otp) are now visually
aligned.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Josua Vogel +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1419

  1. Elias Häußler uploaded patch set 1 10/16/25, 12:41

  2. Elias Häußler uploaded patch set 2 10/16/25, 12:42

  3. core-ci voted on patch set 1 V -1 10/16/25, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86811

  4. core-ci voted on patch set 2 V -1 10/16/25, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86812

  5. Elias Häußler uploaded patch set 3 V -1 10/16/25, 13:36

  6. core-ci voted on patch set 3 V +1 10/16/25, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86816

  7. Benjamin Franzke commented on patch set 3 CR -1 10/16/25, 22:28

    UserPassLoginForm.html:15

    @benjamin.kott@outlook.com are we fine with the appearance of the form when labels are shown? (I'm fine)

    UserPassLoginForm.html:21

    Using email adresses as usernames would be a per-site convention, generally speaking it is confusing to suggest a mail address here, since we technically differentiate between the identifying username and the optional mail address. I'd suggest to remove this placeholder all together, whatever we add here is misleading, as we do not know the username convention of the respective TYPO3 instance.

    UserPassLoginForm.html:43

    I'd not add a placeholder here. `*****` can be confused with `·····` (existing value)
  8. Benjamin Franzke uploaded patch set 4 CR -1 V +1 10/17/25, 12:43

  9. Benjamin Franzke commented on patch set 4 10/17/25, 12:43

    UserPassLoginForm.html:21 Reply

    Done

    UserPassLoginForm.html:43 Reply

    Done
  10. core-ci voted on patch set 4 V +1 10/17/25, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86901

  11. Benjamin Franzke uploaded patch set 5 CR +1 V +1 10/17/25, 13:11

  12. core-ci voted on patch set 5 V +1 10/17/25, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86902

  13. Josua Vogel voted on patch set 5 CR +1 10/20/25, 07:17

  14. Benjamin Franzke wrote 10/22/25, 09:09

    Topic set to tas2025
  15. Benjamin Franzke wrote 10/23/25, 02:46

    Hashtag added: tas2025
  16. Benjamin Franzke wrote 10/23/25, 02:46

    Topic tas2025 removed
  17. Benjamin Kott voted on patch set 5 CR +1 V +1 10/27/25, 18:30

  18. Benjamin Franzke commented on patch set 5 CR +2 V +2 10/27/25, 18:41

    UserPassLoginForm.html:15 Reply

    Acked by Benji.
  19. Benjamin Franzke merged patch set 6 10/27/25, 18:56