Review main Merged

9112[FEATURE] Link errors in Template Object Browser to Template Analyzer

Ingo Renner CR +2 V +2 Easy +17 −5 updated 06/03/13, 20:49

Commit message

The Template Object Browser displays error messages about issues the
template parser found when parsing the TypoScript configuration. These
error messages include the line number where the error occured.

However, these numbers do not correspond to line numbers in TypoScript
records or files. The Template Ananlyzer however provides the "correct"
line numbers. A link to the Template Analyzer and the line number in
the overall TypoScript configuration helps to easily find the error.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Georg Ringer +1
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Philipp Gampe +1

Issues 1

Files 3

Review log 7

  1. Ingo Renner uploaded patch set 2 02/20/12, 18:40

  2. Georg Ringer commented on patch set 2 02/20/12, 18:40

    Looks good to me, but someone else must approve
  3. Philipp Gampe commented on patch set 2 02/20/12, 18:40

    Verified; Looks good to me, but someone else must approve
  4. Mr. Jenkins commented on patch set 1 02/20/12, 18:40

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3335/ : FAILURE
  5. Mr. Jenkins commented on patch set 2 02/20/12, 18:40

  6. Tolleiv Nietsch commented on patch set 2 V 0 02/20/12, 18:40

    by team member; Looks good to me, approved :)
  7. Tolleiv Nietsch merged patch set 2 02/20/12, 18:40