Review main Merged

91120[TASK] Avoid "ord(): Providing an empty string is deprecated"

Stefan Bürk CR +2 V +2 Easy +3 −1 updated 10/17/25, 15:49

Commit message

Composing the value is now done in a local variable and only
passed to `ord()` if not empty, otherwise `(int)0` is used
as fallback matching the outcoming of earlier PHP versions [3].

[1] https://wiki.php.net/rfc/deprecations_php_8_5
[2] https://github.com/php/php-src/commit/93676a0425147de239f3758de6b0bce359dccdc6
[3] https://3v4l.org/kLZGe

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Jochen Roth +1
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Jochen Roth +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Stefan Bürk uploaded patch set 1 10/17/25, 08:36

  2. core-ci voted on patch set 1 V +1 10/17/25, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86879

  3. Stefan Bürk rebased onto patch set 2 V +1 10/17/25, 09:25

  4. core-ci voted on patch set 2 V +1 10/17/25, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86883

  5. Andreas Kienast voted on patch set 2 CR +1 10/17/25, 09:50

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 10/17/25, 13:13

  7. Jochen Roth voted on patch set 2 CR +1 V +1 10/17/25, 15:21

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 10/17/25, 15:22

  9. Stefan Bürk merged patch set 3 10/17/25, 15:49