Review main Merged

91150[TASK] Handle phpstan baseline excludes for ObjectConverterTest

Torben Hansen CR +2 V +2 Easy +3 −20 updated 10/18/25, 13:48

Commit message

With this change, one superfluous variable type declaration
has been removed as well as the associated phpstan baseline
exclude.

Additionally, the unused property and unused constructor
parameter of anonymous classes only used for testing
purposes have been annotated with
`@phpstan-ignore-next-line` resulting in the removal of
two additional excludes in the phpstan baseline.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Torben Hansen uploaded patch set 1 10/18/25, 11:41

  2. core-ci voted on patch set 1 V -1 10/18/25, 11:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86975

  3. Torben Hansen uploaded patch set 2 V -1 10/18/25, 11:55

  4. core-ci voted on patch set 2 V -1 10/18/25, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86976

  5. Torben Hansen uploaded patch set 3 V -1 10/18/25, 12:08

  6. core-ci voted on patch set 3 V +1 10/18/25, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86978

  7. Anja Leichsenring voted on patch set 3 CR +1 V +1 10/18/25, 13:20

  8. Christian Kuhn voted on patch set 3 CR +2 V +2 10/18/25, 13:48

  9. Christian Kuhn merged patch set 4 10/18/25, 13:48