Review main Merged

91161[FEATURE] Register Metadata Extractor Services via Interface

Anja Leichsenring CR +2 V +2 Hard +469 −314 updated 11/02/25, 07:28

Commit message

Explicit registration in ext_localconf.php files is no longer
necessary, extractor services implementing the interface
`TYPO3\CMS\Core\Resource\Index\ExtractorInterface` will be
automatically detected and fed into the registry.

This allows the ExtractoryRegistry to be used via Dependency Injection.

Strong typing is applied to ExtractorRegistry.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 1826

Show 1 earlier messages
  1. Anja Leichsenring uploaded patch set 1 10/19/25, 11:41

  1. core-ci voted on patch set 1 V -1 10/19/25, 11:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87015

  2. Anja Leichsenring uploaded patch set 2 V -1 10/20/25, 05:56

  3. core-ci voted on patch set 2 V -1 10/20/25, 06:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87042

  4. Anja Leichsenring uploaded patch set 3 V -1 10/20/25, 06:10

  5. core-ci voted on patch set 3 V +1 10/20/25, 06:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87043

  6. Anja Leichsenring uploaded patch set 4 V +1 10/20/25, 07:53

  7. Anja Leichsenring uploaded patch set 5 10/20/25, 07:57

  8. core-ci voted on patch set 4 V +1 10/20/25, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87055

  9. core-ci voted on patch set 5 V +1 10/20/25, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87056

  10. Garvin Hicking uploaded patch set 6 V +1 10/26/25, 09:26

  11. core-ci voted on patch set 6 V +1 10/26/25, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87590

  12. Garvin Hicking commented on patch set 6 CR +1 10/26/25, 09:56

    This seems perfect code-wise. However I could not get an actual extractor to work, but that's beyond the scope of this patch because it also doesn't work without the patch. Neither uploading a file nor running the indexing task (because the task only sees 'yeah that file is already indexed').
  13. Garvin Hicking commented on patch set 6 V +1 10/26/25, 10:24

    Utilizing extractors seems broken in main. I could get this to work in 13.4 though (with patch applied)
  14. Garvin Hicking commented on patch set 6 10/26/25, 11:06

    Reply

    Never mind this comment, turns out I had auto-extraction of the "fileadmin" storage record in my instance set to disabled.....
  15. Christian Kuhn commented on patch set 6 10/27/25, 17:30

    ExtractorRegistry.php:52

    i think we could just make this method no-op with only the trigger_error() and remove $this->instances since the service locator will catch classes that implements the interface (which was checked already) automatically?
  16. Garvin Hicking rebased onto patch set 7 CR +1 V +1 10/28/25, 17:04

  17. core-ci voted on patch set 7 V +1 10/28/25, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87868

  18. Christian Kuhn uploaded patch set 8 V +1 10/28/25, 18:07

  19. Christian Kuhn commented on patch set 8 10/28/25, 18:08

    ExtractorRegistry.php:52 Reply

    Done
  20. Christian Kuhn voted on patch set 8 CR +1 V +1 10/28/25, 18:09

  21. core-ci voted on patch set 8 V +1 10/28/25, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87870

  22. Stefan Bürk voted on patch set 8 CR +1 V +1 10/28/25, 19:09

  23. Anja Leichsenring voted on patch set 8 CR +2 V +2 10/28/25, 19:12

  24. Anja Leichsenring merged patch set 9 10/28/25, 19:12

  25. Lina Wolf commented on patch set 9 11/02/25, 07:28

    Unresolved

    Please review documentation: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/6164 The feature had never been documented, I added documentation, however examples are still missing. Would be great if one of you could provide one.