91161[FEATURE] Register Metadata Extractor Services via Interface
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 16
- typo3/sysext/core/Classes/Resource/Index/ExtractorInterface.php+2 −0
- typo3/sysext/core/Classes/Resource/Index/ExtractorRegistry.php2+34 −60
- typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-107783-RegistrationOfMetadataExtractorsViaRegisterExtractionService.rstnew+50 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107783-RegisterMetadataExtractorsViaInterface.rstnew+33 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_metadata_extraction/Classes/Resources/Metadata/Extractors/TextFileExtractor1.phpnew+63 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_metadata_extraction/Classes/Resources/Metadata/Extractors/TextFileExtractor2.phpnew+63 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_metadata_extraction/Classes/Resources/Metadata/Extractors/TextFileExtractor3.phpnew+63 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_metadata_extraction/Configuration/Services.yamlnew+9 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_metadata_extraction/composer.jsonnew+19 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_metadata_extraction/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Resource/Index/ExtractorRegistryTest.phpnew+87 −0
- typo3/sysext/core/Tests/Unit/Resource/Index/ExtractorRegistryTest.phpdeleted+0 −215
- typo3/sysext/core/Tests/Unit/Resource/Service/ExtractorServiceTest.php+12 −28
- typo3/sysext/core/ext_localconf.php+0 −6
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+12 −5
- composer.json+1 −0
Review log 1826
Show 1 earlier messages
-
Anja Leichsenring uploaded patch set 1 10/19/25, 11:41
-
core-ci voted on patch set 1 V -1 10/19/25, 11:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87015
-
Anja Leichsenring uploaded patch set 2
V -110/20/25, 05:56 -
core-ci voted on patch set 2 V -1 10/20/25, 06:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87042
-
Anja Leichsenring uploaded patch set 3
V -110/20/25, 06:10 -
core-ci voted on patch set 3 V +1 10/20/25, 06:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87043
-
Anja Leichsenring uploaded patch set 4
V +110/20/25, 07:53 -
Anja Leichsenring uploaded patch set 5 10/20/25, 07:57
-
core-ci voted on patch set 4 V +1 10/20/25, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87055
-
core-ci voted on patch set 5 V +1 10/20/25, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87056
-
Garvin Hicking uploaded patch set 6
V +110/26/25, 09:26 -
core-ci voted on patch set 6 V +1 10/26/25, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87590
-
Garvin Hicking commented on patch set 6 CR +1 10/26/25, 09:56
This seems perfect code-wise. However I could not get an actual extractor to work, but that's beyond the scope of this patch because it also doesn't work without the patch. Neither uploading a file nor running the indexing task (because the task only sees 'yeah that file is already indexed'). -
Garvin Hicking commented on patch set 6 V +1 10/26/25, 10:24
Utilizing extractors seems broken in main. I could get this to work in 13.4 though (with patch applied) -
Garvin Hicking commented on patch set 6 10/26/25, 11:06
Reply
Never mind this comment, turns out I had auto-extraction of the "fileadmin" storage record in my instance set to disabled..... -
Christian Kuhn commented on patch set 6 10/27/25, 17:30
ExtractorRegistry.php:52i think we could just make this method no-op with only the trigger_error() and remove $this->instances since the service locator will catch classes that implements the interface (which was checked already) automatically? -
Garvin Hicking rebased onto patch set 7
CR +1V +110/28/25, 17:04 -
core-ci voted on patch set 7 V +1 10/28/25, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87868
-
Christian Kuhn uploaded patch set 8
V +110/28/25, 18:07 -
Christian Kuhn commented on patch set 8 10/28/25, 18:08
ExtractorRegistry.php:52ReplyDone -
Christian Kuhn voted on patch set 8 CR +1 V +1 10/28/25, 18:09
-
core-ci voted on patch set 8 V +1 10/28/25, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87870
-
Stefan Bürk voted on patch set 8 CR +1 V +1 10/28/25, 19:09
-
Anja Leichsenring voted on patch set 8 CR +2 V +2 10/28/25, 19:12
-
Anja Leichsenring merged patch set 9 10/28/25, 19:12
-
Lina Wolf commented on patch set 9 11/02/25, 07:28
Unresolved
Please review documentation: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/6164 The feature had never been documented, I added documentation, however examples are still missing. Would be great if one of you could provide one.