Review main Merged

91162[DOCS] Correct example for BeforeLabelResourceResolvedEvent in changelog

TYPO3com CR +2 V +2 Easy +11 −8 updated 10/27/25, 13:42

Commit message

The event has neither a property called `extensionKey` nor one called
domain

Property $domains is an array and it seems like $extensionKey has been
renamed to $packageKey.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1525

  1. TYPO3com uploaded patch set 1 10/20/25, 07:02

  2. Lina Wolf commented on patch set 1 10/20/25, 07:02

    watching
  3. Lina Wolf updated the commit message in patch set 2 10/20/25, 07:02

  4. Lina Wolf updated the commit message in patch set 3 10/20/25, 07:03

  5. core-ci voted on patch set 1 V +1 10/20/25, 07:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87045

  6. Lina Wolf commented on patch set 3 10/20/25, 07:12

    Additionally, after reading the code in TranslationDomainMapper some, it seems like $domains would not contain the package name part of the domain but only the part pointing at the file name. Therefore wanting to replace the first part of the domain my_extension.messages:my_label => myext.messages:my_label As the example suggests, would that really work? It seems to me like we can only change the second part with this event: my_extension.messages:my_label => my_extension.my_cool_labels:my_label Or do I misunderstand the code?
  7. core-ci voted on patch set 2 V +1 10/20/25, 07:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87046

  8. Lina Wolf updated the commit message in patch set 4 10/20/25, 07:14

  9. Lina Wolf updated the commit message in patch set 5 10/20/25, 07:15

  10. core-ci voted on patch set 3 V +1 10/20/25, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87047

  11. core-ci voted on patch set 4 V +1 10/20/25, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87049

  12. core-ci voted on patch set 5 V +1 10/20/25, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87050

  13. Lina Wolf commented on patch set 6 V +1 10/20/25, 07:34

    Published edit on patch set 5.
  14. Lina Wolf commented on patch set 6 10/20/25, 07:36

    Reply

    Ok so after some more checking, $domains actually contains an array where the translation domain part is the key and the values are references to the file. Usually but not limited to the `EXT:` format.
  15. Lina Wolf commented on patch set 7 10/20/25, 07:37

    Published edit on patch set 6.
  16. Lina Wolf commented on patch set 8 10/20/25, 07:40

    Published edit on patch set 7.
  17. core-ci voted on patch set 6 V +1 10/20/25, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87052

  18. core-ci voted on patch set 7 V +1 10/20/25, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87053

  19. core-ci voted on patch set 8 V +1 10/20/25, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87054

  20. Lina Wolf commented on patch set 8 10/22/25, 14:04

    Reply

    Done
  21. Lina Wolf commented on patch set 9 V +1 10/27/25, 13:28

    Published edit on patch set 8.
  22. Garvin Hicking voted on patch set 9 CR +1 V +1 10/27/25, 13:29

  23. core-ci voted on patch set 9 V +1 10/27/25, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87659

  24. Benni Mack voted on patch set 9 CR +2 V +2 10/27/25, 13:42

  25. Benni Mack merged patch set 10 10/27/25, 13:42