Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
91178[!!!][FEATURE] Autoconfigure backend login providers
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 6
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/78/91178/6 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/78/91178/6 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -1 Needs a vote
- Elias Häußler -1
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Classes/Controller/LoginController.php4+3 −5
- typo3/sysext/backend/Classes/LoginProvider/LoginProviderInterface.php+19 −0
- typo3/sysext/backend/Classes/LoginProvider/LoginProviderResolver.php+41 −32
- typo3/sysext/backend/Classes/LoginProvider/UsernamePasswordLoginProvider.php+20 −2
- typo3/sysext/backend/Tests/Unit/LoginProvider/LoginProviderResolverTest.php+98 −127
- typo3/sysext/backend/ext_localconf.php+0 −8
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107870-RemoveBackendLoginProviderRegistrationViaGLOBALS.rstnew+98 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107870-AutoconfigureBackendLoginProviders.rstnew+77 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+6 −0
Review log 1622
-
Elias Häußler uploaded patch set 1 10/21/25, 08:07
-
core-ci voted on patch set 1 V -1 10/21/25, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87147
-
Elias Häußler uploaded patch set 2
V -110/21/25, 08:19 -
core-ci voted on patch set 2 V +1 10/21/25, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87152
-
Elias Häußler uploaded patch set 3
V +110/27/25, 20:20 -
Elias Häußler marked it ready for review 10/27/25, 20:20
-
Elias Häußler updated the commit message in patch set 4 10/27/25, 20:23
-
Sven Liebert commented on patch set 4 CR +1 V +1 10/27/25, 20:30
Nice one. Thank you :) -
core-ci voted on patch set 3 V +1 10/27/25, 20:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87735
-
core-ci voted on patch set 4 V +1 10/27/25, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87738
-
Christian Kuhn commented on patch set 4 CR -1 10/31/25, 01:16
LoginController.php:63I'm not a huge fan of the patch since it works on a construct that is doomed in the first place as described above. I think we shouldn't change the registration of LoginProviderInterface implementations, but should resolve the main issue which can come with improved registration along the way. We'd otherwise end up with devs having to change this twice. -
Simon Schaufelberger commented on patch set 4 11/07/25, 17:11
LoginController.php:63Replyping -
Elias Häußler commented on patch set 4 11/10/25, 14:38
LoginController.php:63Reply@lolli@schwarzbu.ch Thank you for sharing your thoughts about this topic. I agree that we should not change this API multiple times (especially if the changes are breaking). Do you see any chances to adapt the template rendering logic as well, if we're about to change the public API for backend login providers anyway? I'd be happy to continue working on this topic, but need some background and your thoughts in what direction this could probably go. -
Elias Häußler uploaded patch set 5
CR +1V +111/13/25, 20:37 -
core-ci voted on patch set 5 V +1 11/13/25, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89587
-
Christian Kuhn commented on patch set 5 11/13/25, 22:13
LoginController.php:63Reply Unresolvedi have no good plan in this case if this is the question. i'm open to team up and see if we can come up with one. -
Elias Häußler uploaded patch set 6
V +111/20/25, 17:32 -
core-ci voted on patch set 6 V +1 11/20/25, 17:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90336
-
Elias Häußler commented on patch set 6 CR -1 11/20/25, 18:30
I talked with @lolli@schwarzbu.ch and we decided to hold off on this patch for now. Reason: The patch touches a broader area that needs proper refactoring and consolidation. This includes the whole backend authentication stuff, MFA, re-login and so on. We'll come back to this patch once we're starting with refactoring in this area. -
Stefan Bürk marked it work in progress 11/24/25, 18:18
-
Stefan Bürk commented on patch set 6 11/24/25, 18:19
Reply
Set to work-in-progress to have it out of the "reviewable" list, the mentioned refactored sounds that this is not done in the nearer time. Hope that's okay @elias@haeussler.dev. -
Elias Häußler commented on patch set 6 11/24/25, 20:18
Reply
Sure, thanks 👍